Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the option to route requests through a proxy #30

Closed
Lcchy opened this issue Feb 12, 2024 · 2 comments · Fixed by #32
Closed

Adding the option to route requests through a proxy #30

Lcchy opened this issue Feb 12, 2024 · 2 comments · Fixed by #32

Comments

@Lcchy
Copy link
Contributor

Lcchy commented Feb 12, 2024

For my use of rsspls I have added the option to route all requests through a proxy url (my home residiential IP, while rsspls runs on a VPS which gets blocked) specified in the [rsspls] section of feeds.toml. It supports socks5, http and https proxies with a quite minimal code change.

Would you be ok with a PR for this feature?

@wezm
Copy link
Owner

wezm commented Feb 12, 2024

Would you be ok with a PR for this feature?

Yes in principle this sounds ok. Does it require extra dependencies?

specified in the [rsspls] section of feeds.toml

My understanding is that proxy settings are typically set in the environment so that each individual program does not need to be configured. It seems like supporting these in preference to or in addition to the config file would be ideal:

  • http_proxy
  • HTTPS_PROXY

https://superuser.com/a/1690537/60136 (above is compatible with curl)

@Lcchy
Copy link
Contributor Author

Lcchy commented Feb 17, 2024

Sounds good! it just adds needs an additional feature to the reqwest create.

I am going to open the PR then.

Ps: FYI I just found out that this also enables using external scraping tools like headless browsers through projects like this:
https://github.com/FlareSolverr/FlareSolverr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants