-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset event stream unit test #175
Merged
Merged
Commits on Jul 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4e8a07c - Browse repository at this point
Copy the full SHA 4e8a07cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e10b43d - Browse repository at this point
Copy the full SHA e10b43dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b71694c - Browse repository at this point
Copy the full SHA b71694cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a8b397 - Browse repository at this point
Copy the full SHA 2a8b397View commit details
Commits on Oct 25, 2021
-
fix: 🐛 try to stop grpcStream evenif grpcClient does not exist
1. grpcStream method will not fail even if stream does not exist; 2. grpcStream might exist even if grpcClient does not ✅ Closes: #172
Configuration menu - View commit details
-
Copy full SHA for e0118c2 - Browse repository at this point
Copy the full SHA e0118c2View commit details -
fix: 🐛 recreate gRPC stream when it already exists
I think it's better to warn and recreate stream since the upper level bot does not have direct access to these private method to handle it properly. ✅ Closes: #172
Configuration menu - View commit details
-
Copy full SHA for 9f0d201 - Browse repository at this point
Copy the full SHA 9f0d201View commit details
Commits on Oct 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4041e5f - Browse repository at this point
Copy the full SHA 4041e5fView commit details -
as we close stream in the previos commit, start with event stream should never happen, thus if somehow this happened, an exception shold be thrown
Configuration menu - View commit details
-
Copy full SHA for a252200 - Browse repository at this point
Copy the full SHA a252200View commit details -
Configuration menu - View commit details
-
Copy full SHA for e347c82 - Browse repository at this point
Copy the full SHA e347c82View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa3fb84 - Browse repository at this point
Copy the full SHA aa3fb84View commit details
Commits on Oct 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6c9070e - Browse repository at this point
Copy the full SHA 6c9070eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cb5805 - Browse repository at this point
Copy the full SHA 3cb5805View commit details
Commits on Oct 31, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8bdc0fd - Browse repository at this point
Copy the full SHA 8bdc0fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53413ca - Browse repository at this point
Copy the full SHA 53413caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37f8661 - Browse repository at this point
Copy the full SHA 37f8661View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c8db9a - Browse repository at this point
Copy the full SHA 8c8db9aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.