Reset event stream unit test #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. grpcStream method will not fail even if stream does not exist; 2. grpcStream might exist even if grpcClient does not ✅ Closes: #172
I think it's better to warn and recreate stream since the upper level bot does not have direct access to these private method to handle it properly. ✅ Closes: #172
as we close stream in the previos commit, start with event stream should never happen, thus if somehow this happened, an exception shold be thrown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have cherry-picked the unit test to this PR to confirm that this test can fail with our current code base so that we can confirm that this is the problem.