Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bare imports not working sometimes #579

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Conversation

jhnns
Copy link
Member

@jhnns jhnns commented Jun 4, 2018

Fixes #566
Supersedes #577

@codecov
Copy link

codecov bot commented Jun 4, 2018

Codecov Report

Merging #579 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #579   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files           6        6           
  Lines         122      122           
=======================================
  Hits          119      119           
  Misses          3        3
Impacted Files Coverage Δ
lib/importsToResolve.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2efb8cf...0fda871. Read the comment docs.

@emilio-martinez
Copy link

Reading the diff, would this not also solve for #556?

@alexander-akait
Copy link
Member

@emilio-martinez no

@alexander-akait alexander-akait merged commit c348281 into master Jun 4, 2018
@alexander-akait alexander-akait deleted the fix/issue-566 branch June 4, 2018 09:32
@jhnns
Copy link
Member Author

jhnns commented Jun 5, 2018

Shipped with 7.0.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants