fix: alias module request from multiple loaders #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
Jun 1, 2018
| @@ -3,7 +3,7 @@ | |||
| const path = require("path"); | |||
| const utils = require("loader-utils"); | |||
|
|
|||
| const matchModuleImport = /^~([^\/]+|@[^\/]+[\/][^\/]+)$/g; | |||
| const matchModuleImport = /^~([^\/]+|@[^\/]+[\/][^\/]+)$/; | |||
There was a problem hiding this comment.
A lot of test lines around one characters 🤕
There was a problem hiding this comment.
Using g modify matchModuleImport.lastIndex and broke behavior as expected
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 6 6
Lines 122 122
=======================================
Hits 119 119
Misses 3 3
Continue to review full report at Codecov.
|
|
Thanks for providing a test case. I managed to reproduce the problem with a simpler test, so I'm closing this. But anyway, thanks 👍 |
alexander-akait
pushed a commit
that referenced
this pull request
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #566