This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Fix OCIString parsing of local docker images #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
commented
Mar 9, 2020
| @@ -6,6 +6,10 @@ import ( | |||
| "net/url" | |||
| "strings" | |||
|
|
|||
| // "github.com/opencontainers/go-digest" requires us to load the algorithms | |||
| // that we want to use into the binary. (it calls algorithm.Available) | |||
| _ "crypto/sha256" | |||
There was a problem hiding this comment.
Got this from @stealthybox 's branch https://github.com/stealthybox/ignite/blob/fix-oci-ref/pkg/apis/meta/v1alpha1/image.go#L9-L11 . Without this, the test run fails with "unsupported digest algorithm" error.
Local docker images don't have repo name in the OCI string. Example: docker://sha256:fce289e99eb9bca977dae136fbe2a82b6b7d4c372474c9235adc1741675f587e URL parsing OCI string of local docker image fails because of the invalid url format.
darkowlzz
force-pushed
the
parseOCIString-local-image
branch
from
28c8161
to
2fa2992
Compare
|
Related #465 |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local docker images don't have repo name in the OCI string.
Example:
docker://sha256:fce289e99eb9bca977dae136fbe2a82b6b7d4c372474c9235adc1741675f587eURL parsing OCI string of local docker image fails because of the
invalid url format.
I was working on local image import from a tar file and came across this issue when importing with runtime docker. Importing with containerd resulted in proper OCI string with repo name in it. When
/var/lib/firecracker/imagecontains any image metadata with invalid OCI source ID, any ignite execution that reads images starts failing with errors like:After debugging, the actual error was about the URL parse failure at
parseOCIString():Adds tests to verify the fix.