could not parse image with a tag: image based on digest fails

[lucidprogrammer]

Looks like we cannot create VM based on a specific image hash.

sudo ignite launch weaveworks/ignite-kubeadm@sha256:928f55c6162a50d3278e334ac0d7a6e0bf7c765d9c6dd835b935f0ca73e398ca \
    --cpus 2 \
    --memory 1GB \
    --ssh \
    --name master-1
FATA[0000] could not parse image "weaveworks/ignite-kubeadm@sha256:928f55c6162a50d3278e334ac0d7a6e0bf7c765d9c6dd835b935f0ca73e398ca" with a tag

It was ideal if this feature is available

[chanwit]

Thank you for reporting!

[stealthybox]

ignite launch is not a valid subcommand, but I am able to reproduce this with ignite run:

sudo ignite run --log-level=trace weaveworks/ignite-kubeadm@sha256:928f55c6162a50d3278e334ac0d7a6e0bf7c765d9c6dd835b935f0ca73e398ca 
TRAC[0000] Populating providers...                      
TRAC[0000] Initializing the containerd runtime provider... 
TRAC[0000] Initializing the CNI provider...             
FATA[0000] could not parse image "weaveworks/ignite-kubeadm@sha256:928f55c6162a50d3278e334ac0d7a6e0bf7c765d9c6dd835b935f0ca73e398ca" with a tag 

[stealthybox]

I've begun working on this.
#467 allows us to do some functional testing.

I fixed the parser on this branch:
https://github.com/stealthybox/ignite/blob/fix-oci-ref/pkg/apis/meta/v1alpha1/image.go

Just chasing down runtime issues now.

[stealthybox]

ignite image import of digest refs works with --runtime docker / fails with --runtime containerd

Once the image is imported correctly into ignite, named by the digest, ignite run fails with both runtimes. ignite-spawn seems to time out.
Initial suspicion is that the sandbox is not inflated correctly for digest images.

A storage refactor will be necessary to clean up these bugs related to digests.

ps: I rebased my branch

[stealthybox]

Sunny's patch has to do with supporting tar image import.
The metadata that results from a docker image save may include image name.
The result from from docker image load will not have a name/tag.
Overriding the name/tag is optional on docker image import.