Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace point pred with bootstrap mean #102

Merged

Conversation

lennybronner
Copy link
Collaborator

@lennybronner lennybronner commented Sep 5, 2024

Description

We are replacing the unit level point prediction with the bootstrap sample mean.

This makes sure that the point prediction is always centered around the average of error_B_1, which forces our interval to be the error_B_2's (fake test error) deviation from that. This would make issues around weirdly shaped intervals easier to debug on election night.

Jira Ticket

https://arcpublishing.atlassian.net/browse/ELEX-4464

Test Steps

elexmodel 2017-11-07_VA_G --estimands=margin --office_id=G --geographic_unit_type=county --pi_method bootstrap --features baseline_normalized_margin --percent_reporting 10 --aggregates postal_code --aggregates county_classification

@lennybronner lennybronner requested a review from a team as a code owner September 5, 2024 02:09
@dmnapolitano dmnapolitano self-assigned this Sep 5, 2024
Copy link
Contributor

@dmnapolitano dmnapolitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 🎉 🎉

Copy link
Collaborator

@jjcherian jjcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@lennybronner lennybronner merged commit 5569c56 into develop Sep 9, 2024
3 checks passed
@lennybronner lennybronner deleted the elex-4465-replace-point-prediction-with-bootstrap-mean branch September 9, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants