Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log enr only after it has been setup #721

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

richard-ramos
Copy link
Member

Description

The node's ENR was being displayed logged it had its information setup, rendering it useless. This PR changes that so the enr is shown after setupENR is executed

@status-im-auto
Copy link

status-im-auto commented Sep 8, 2023

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 13ea8e7 #1 2023-09-08 19:23:12 ~1 min nix-flake 📄log
✔️ 13ea8e7 #1 2023-09-08 19:23:30 ~2 min linux 📦deb
✔️ 13ea8e7 #1 2023-09-08 19:24:22 ~3 min tests 📄log
✔️ 13ea8e7 #1 2023-09-08 19:24:25 ~3 min tests 📄log
✔️ 13ea8e7 #1 2023-09-08 19:24:59 ~3 min android 📦tgz
✔️ 13ea8e7 #1 2023-09-08 19:25:46 ~4 min ios 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ aa0660d #2 2023-09-08 21:27:05 ~1 min tests 📄log
✔️ aa0660d #2 2023-09-08 21:27:43 ~1 min nix-flake 📄log
✔️ aa0660d #2 2023-09-08 21:27:57 ~2 min linux 📦deb
✔️ aa0660d #2 2023-09-08 21:28:39 ~2 min tests 📄log
✔️ aa0660d #2 2023-09-08 21:29:42 ~3 min ios 📦tgz
✔️ aa0660d #2 2023-09-08 21:29:50 ~3 min android 📦tgz
✔️ 7f68d30 #3 2023-09-08 21:27:57 ~47 sec tests 📄log
✔️ 7f68d30 #3 2023-09-08 21:29:36 ~1 min nix-flake 📄log
✔️ 7f68d30 #3 2023-09-08 21:30:10 ~2 min linux 📦deb
✔️ 7f68d30 #3 2023-09-08 21:30:25 ~1 min tests 📄log
✔️ 7f68d30 #3 2023-09-08 21:33:09 ~6 min ios 📦tgz
✔️ 7f68d30 #3 2023-09-08 21:33:53 ~4 min android 📦tgz

@richard-ramos richard-ramos marked this pull request as draft September 8, 2023 20:09
@richard-ramos richard-ramos marked this pull request as ready for review September 8, 2023 21:26
@richard-ramos
Copy link
Member Author

Merging this PR as the change is trivial

@richard-ramos richard-ramos merged commit db3a2d5 into master Sep 8, 2023
9 of 11 checks passed
@richard-ramos richard-ramos deleted the fix/enr-display branch September 8, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants