fix: log enr only after it has been setup

waku-org · Sep 8, 2023 · aa0660d · aa0660d
1 parent cc28267
commit aa0660d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/cmd/waku/flags.go b/cmd/waku/flags.go
@@ -3,7 +3,7 @@ package main
 import (
 	"time"
 
-	cli "github.com/urfave/cli/v2"
+	"github.com/urfave/cli/v2"
 	"github.com/urfave/cli/v2/altsrc"
 	"github.com/waku-org/go-waku/waku/cliutils"
 )

diff --git a/waku/v2/node/localnode.go b/waku/v2/node/localnode.go
@@ -281,6 +281,8 @@ func (w *WakuNode) setupENR(ctx context.Context, addrs []ma.Multiaddr) error {
 		}
 	}
 
+	w.enrChangeCh <- struct{}{}
+
 	return nil
 
 }

diff --git a/waku/v2/node/wakunode2.go b/waku/v2/node/wakunode2.go
@@ -310,7 +310,6 @@ func (w *WakuNode) watchMultiaddressChanges(ctx context.Context) {
 			return
 		case <-first:
 			w.log.Info("listening", logging.MultiAddrs("multiaddr", addrs...))
-			w.enrChangeCh <- struct{}{}
 		case <-w.addressChangesSub.Out():
 			newAddrs := w.ListenAddresses()
 			diff := false
@@ -327,8 +326,10 @@ func (w *WakuNode) watchMultiaddressChanges(ctx context.Context) {
 			if diff {
 				addrs = newAddrs
 				w.log.Info("listening addresses update received", logging.MultiAddrs("multiaddr", addrs...))
-				_ = w.setupENR(ctx, addrs)
-				w.enrChangeCh <- struct{}{}
+				err := w.setupENR(ctx, addrs)
+				if err != nil {
+					w.log.Warn("could not update ENR", zap.Error(err))
+				}
 			}
 		}
 	}