Add auto cluster configuration support #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatpat
force-pushed
the
cluster_support
branch
7 times, most recently
from
fa40bee
to
79e6f6b
Compare
|
Still working on tests... |
fatpat
force-pushed
the
cluster_support
branch
4 times, most recently
from
901f8dd
to
bed4aeb
Compare
|
tests are now all green. Only one is failing due to network issues. it's good to me |
|
it would be great to include this PR in the coming release (Release 11.1.0 #879) |
|
@fatpat have you tested this with an actual auto-cluster setup as well? Only other question is, it seems like the original author still has some credit from the commit email; if this is based on one or more previous PRs, is it worth also mentioning the authors in the commit message? |
wyardley
reviewed
Apr 20, 2021
- added clustername fact and spec tests for it - added rabbitmq_cluster type and provider with tests - added related doc - based from PR#736, credits to @vchepkov
yes this has been tested and we used it in production.
fixed in the commit message. My mistake |
wyardley
approved these changes
Apr 20, 2021
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
Apr 20, 2021
- Add support for oom_score_adj (voxpupuli#877) - CLI Environment Fixes (voxpupuli#876) - make sure the rabbitmq_version method actually returns the version (voxpupuli#874) - Use mocked facts in tests (voxpupuli#873) - Enable Puppet 7 support (voxpupuli#881) - Add auto cluster configuration support (voxpupuli#883)
Merged
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
May 6, 2021
- Add support for oom_score_adj (voxpupuli#877) - CLI Environment Fixes (voxpupuli#876) - make sure the rabbitmq_version method actually returns the version (voxpupuli#874) - Use mocked facts in tests (voxpupuli#873) - Enable Puppet 7 support (voxpupuli#881) - Add auto cluster configuration support (voxpupuli#883)
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
May 6, 2021
- Add support for oom_score_adj (voxpupuli#877) - CLI Environment Fixes (voxpupuli#876) - make sure the rabbitmq_version method actually returns the version (voxpupuli#874) - Use mocked facts in tests (voxpupuli#873) - Enable Puppet 7 support (voxpupuli#881) - Add auto cluster configuration support (voxpupuli#883) - Compatibility with camptocamp/systemd 3.x (voxpupuli#886)
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
May 6, 2021
- Add support for oom_score_adj (voxpupuli#877) - CLI Environment Fixes (voxpupuli#876) - make sure the rabbitmq_version method actually returns the version (voxpupuli#874) - Use mocked facts in tests (voxpupuli#873) - Enable Puppet 7 support (voxpupuli#881) - Add auto cluster configuration support (voxpupuli#883) - Compatibility with camptocamp/systemd 3.x (voxpupuli#886) - puppetlabs/apt: Allow 8.x (voxpupuli#884) - puppet/archive: Allow 5.x (voxpupuli#884) - puppetlabs/stdlib: allow 7.x (voxpupuli#884)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR add the clustering management
This Pull Request (PR) fixes the following issues
Fixes #792
Closes #736