Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto cluster configuration support #736

Conversation

vchepkov
Copy link

  • added clustername fact and spec tests for it
  • added rabbitmq_cluster type and provider with tests

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak
Copy link
Member

Hey @vchepkov, thanks for picking this up. Can you take a look at the failing travis jobs?

@vchepkov
Copy link
Author

I afraid tests are not my forte. I will see if I can copy&paste something, that's an extent of my expertise here :)

@vchepkov vchepkov force-pushed the add_auto_cluster_configuration_support branch 3 times, most recently from b2399bf to 1b66166 Compare October 19, 2018 16:02
- added clustername fact and spec tests for it
- added rabbitmq_cluster type and provider with tests
@vchepkov vchepkov force-pushed the add_auto_cluster_configuration_support branch from 1b66166 to 03ab549 Compare October 19, 2018 16:30
@KlavsKlavsen
Copy link

Really hoping this gets in.. would make cluster setup soo much easier :)

@KlavsKlavsen
Copy link

I just realized that if you give rabbitmq nodenames in FQDN format - it removes the domain part - and you cannot join - unless you give that name (ie. hostname part only). But in the acceptance test here - init_node is set from $facts['fqdn'] - which won't work..
This should probably strip domain name part of a node name - before trying to join atleast.

@vox-pupuli-tasks
Copy link

Dear @vchepkov, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

1 similar comment
@vox-pupuli-tasks
Copy link

Dear @vchepkov, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @vchepkov, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

1 similar comment
@vox-pupuli-tasks
Copy link

Dear @vchepkov, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@Fabian1976
Copy link

I ran in to this issue also because i used FQDN as cluster_node names

rabbitmq::cluster_nodes:
  - 'local-o-rmq001.example.com'
  - 'local-o-rmq002.example.com'
  - 'local-o-rmq003.example.com'

But switching them to hostname only:

rabbitmq::cluster_nodes:
  - 'local-o-rmq001'
  - 'local-o-rmq002'
  - 'local-o-rmq003'

(and make sure they would resolve in DNS, made the cluster work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants