-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto cluster configuration support #736
Add auto cluster configuration support #736
Conversation
a83e321
to
8290837
Compare
Hey @vchepkov, thanks for picking this up. Can you take a look at the failing travis jobs? |
I afraid tests are not my forte. I will see if I can copy&paste something, that's an extent of my expertise here :) |
b2399bf
to
1b66166
Compare
- added clustername fact and spec tests for it - added rabbitmq_cluster type and provider with tests
1b66166
to
03ab549
Compare
Really hoping this gets in.. would make cluster setup soo much easier :) |
I just realized that if you give rabbitmq nodenames in FQDN format - it removes the domain part - and you cannot join - unless you give that name (ie. hostname part only). But in the acceptance test here - init_node is set from $facts['fqdn'] - which won't work.. |
Dear @vchepkov, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
Dear @vchepkov, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Dear @vchepkov, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
Dear @vchepkov, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
I ran in to this issue also because i used FQDN as cluster_node names
But switching them to hostname only:
(and make sure they would resolve in DNS, made the cluster work. |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues