Native firewalld custom service

[trevor-vaughan]

• Create firewalld_custom_service type and provider
• Add spec tests
• Update Beaker tests
• Mark firewalld::custom_service for deprecation
• Resolve dependency loops

Fixes #275

[trevor-vaughan]

Coverage went down even though it has more tests than it's ever had before. Not correcting at this time.

[alexjfisher]

Coverage went down even though it has more tests than it's ever had before. Not correcting at this time.

That's not why the tests are failing though.

[trevor-vaughan]

Oh, I see. Got buried in the garbage.

[trevor-vaughan]

@alexjfisher OK, one more try :-|

[alexjfisher]

I’d like to try this out one more time before merging. Probably tomorrow.

[alexjfisher]

I've confirmed this is a breaking change for me. The following two resources worked before, but don't any more.

firewalld::custom_service { 'foreman-smart-proxy':
    filename    => 'foreman-smart-proxy',
    short       => 'Foreman Smart Proxy',
    description => 'Smart Proxy is a free open source project that provides restful API to subsystems such as DNS, DHCP, etc, for higher level orchestration tools such as Foreman.',
    port        => [
      {
        'port'     => '8443',
        'protocol' => 'tcp',
      },
    ],
  }
firewalld_service { 'Allow Foreman Smart Proxy from public zone':
    ensure  => 'present',
    service => 'foreman-smart-proxy',
    zone    => 'public',
}

Error: Execution of '/bin/firewall-cmd --permanent --zone public --add-service foreman-smart-proxy' returned 101: 
Error: /Stage[main]/Main/Firewalld_service[Allow Foreman Smart Proxy from public zone]/ensure: change from 'absent' to 'present' failed: Execution of '/bin/firewall-cmd --permanent --zone public --add-service foreman-smart-proxy' returned 101: 
Notice: /Stage[main]/Firewalld::Reload/Exec[firewalld::reload]: Dependency Firewalld_service[Allow Foreman Smart Proxy from public zone] has failures: true
Warning: /Stage[main]/Firewalld::Reload/Exec[firewalld::reload]: Skipping because of failed dependencies
Warning: /Stage[main]/Firewalld::Reload::Complete/Exec[firewalld::complete-reload]: Skipping because of failed dependencies
Notice: /Stage[main]/Main/Firewalld::Custom_service[foreman-smart-proxy]/Firewalld_custom_service[Foreman Smart Proxy]/ensure: created

[trevor-vaughan]

@alexjfisher Can you check this again when you have time please?

[trevor-vaughan]

@alexjfisher Did a full refactor and beefed up the acceptance tests significantly to cover (what I hope) is all of the use cases.

[alexjfisher]

LTGM. I can't break anything anymore. This should be squashed down to 1 (or just a few commits) before merging please.