Native firewalld_custom_service

* Create firewalld_custom_service type and provider
* Add spec tests
* Update Beaker tests
* Mark firewalld::custom_service for deprecation
* Resolve dependency loops

Fixes #275

lib/puppet/provider/firewalld_custom_service/firewall_cmd.rb

@@ -15,6 +15,8 @@ def exists?
 
   def create
     debug("Adding new custom service to firewalld: #{@resource[:name]}")
+    @property_hash[:created] = true
+
     require 'tempfile'
 
     service_file = Tempfile.new(['puppet_firewalld_custom_service', '.xml'])
@@ -33,6 +35,8 @@ def create
   end
 
   def destroy
+    @property_hash[:destroyed] = true
+
     delete_service
   end
 

manifests/custom_service.pp

@@ -48,10 +48,10 @@
     'ports'            => $port,
     'modules'          => $module,
     'ipv4_destination' => $destination.dig('ipv4'),
-    'ipv6_destination' => $destination.dig('ipv6')
+    'ipv6_destination' => $destination.dig('ipv6'),
   })
 
   firewalld_custom_service { $short:
-    * => $_args
+    * => $_args,
   }
 }

spec/unit/puppet/type/firewalld_custom_service_spec.rb

@@ -18,10 +18,6 @@
       resource = described_class.new(name: 'test_test')
       expect(resource[:name]).to eq('test_test')
     end
-
-    it 'rejects invalid names' do
-      expect { described_class.new(name: 'bad name') }.to raise_error(%r{Valid values match})
-    end
   end
 
   context ':description validation' do