Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild RHEL facts on Vagrant #277

Closed
wants to merge 3 commits into from
Closed

Conversation

yakatz
Copy link
Contributor

@yakatz yakatz commented Jul 3, 2023

Fixes #276

@yakatz yakatz force-pushed the rhel9 branch 3 times, most recently from 7399caa to be1fe9b Compare July 4, 2023 16:26
"mtu_lo": 65536,
"netmask": "255.255.255.0",
"netmask6": "ffff:ffff:ffff:ffff::",
"netmask6_eth0": "ffff:ffff:ffff:ffff::",
"netmask6_eth1": "ffff:ffff:ffff:ffff::",
"netmask6_lo": "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to stay as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be multiple network interfaces? I can enable IPv6 for lo, but there is no eth1

"netmask_lo": "255.0.0.0",
"network": "10.0.2.0",
"network6": "fe80::",
"network6_eth0": "fe80::",
"network6_eth1": "fe80::",
"network6_lo": "::1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any facts that were missing previously and that you added, so maybe don't edit this factset at all?

@zilchms
Copy link
Contributor

zilchms commented Mar 12, 2024

@yakatz how is the status on this? :) stumbled upon errors in a different module due to the inconsistencies you address. any plans on addressing the feedback bastelfreak gave you and getting this PR merged? :)

@yakatz
Copy link
Contributor Author

yakatz commented Mar 12, 2024

any plans on addressing the feedback bastelfreak gave you and getting this PR merged?

If course I have plans :-)
On the other hand, I have a deadline coming up to get my PhD dissertation done and I shouldn't be working on anything but that right now. If I need a break from writing, I will see if I can get back to this.

@zilchms
Copy link
Contributor

zilchms commented Mar 13, 2024

Dissertation definitely has priority :) good luck on that

@yakatz
Copy link
Contributor Author

yakatz commented Mar 19, 2024

Rather than try to rebase this, I am closing this and starting again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IP addresses are different on RedHat and other distributions
4 participants