This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Adds support for whitespace chars in Datastore names on Windows #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds handling to correctly map volumes with whitespace characters in its name.
msterin
suggested changes
Aug 11, 2017
venilnoronha
force-pushed
the
win-space-fix
branch
from
51ac031
to
b1c05ec
Compare
venilnoronha
force-pushed
the
win-space-fix
branch
from
b1c05ec
to
50c5d67
Compare
pshahzeb
approved these changes
Aug 11, 2017
|
@pshahzeb thanks! I've updated the test details. |
govint
approved these changes
Aug 14, 2017
venilnoronha
changed the title
9 tasks
msterin
approved these changes
Aug 17, 2017
shuklanirdesh82
pushed a commit
that referenced
this pull request
Aug 18, 2017
This commit adds handling to correctly map volumes with whitespace characters in its name.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling to correctly map volumes with whitespace characters in its name. Testing was done manually i.e. a volume was created with
docker volume create --driver=vsphere "newvolume@local .3 - 0", and attached withdocker run -it -v "newvolume@local .3 - 0:C:/mountpoint/" microsoft/nanoserver powershell, and the following log was observed.See #1724 for original issue.