Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Commit

Permalink
Addresses review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
venilnoronha committed Aug 11, 2017
1 parent 05389ec commit b1c05ec
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion esx_service/vmdk_ops_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def test_name_parse(self):
"""checks name parsing and error checks
'volume[@datastore]' -> volume and datastore"""
testInfo = [
# [ full_name. expected_vol_name, expected_datastore_name, expected_success? ]
# [ full_name, expected_vol_name, expected_datastore_name, expected_success? ]
["MyVolume123_a_.vol@vsanDatastore_11", "MyVolume123_a_.vol", "vsanDatastore_11", True],
["a1@x", "a1", "x", True],
["a1", "a1", None, True],
Expand All @@ -88,6 +88,7 @@ def test_name_parse(self):
"Just100Chars0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567", None, True],
["Volume.123@dots.dot", "Volume.123", "dots.dot", True],
["simple_volume", "simple_volume", None, True],
["spacesindatastore@local .3 - 0", "spacesindatastore", "local .3 - 0", True],
]
for unit in testInfo:
full_name, expected_vol_name, expected_ds_name, expected_result = unit
Expand Down

0 comments on commit b1c05ec

Please sign in to comment.