Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature fill missing steps #5

Closed
wants to merge 3 commits into from

Conversation

breml
Copy link
Contributor

@breml breml commented Apr 25, 2014

An other enhancement to fill missing steps (gaps in timeseries) with None (null) values. This allows to generate correct graphs in Graphite-Web even if there are for some reason some values missing (e.g. caused by a network interrupt).

brutasse and others added 3 commits April 11, 2014 21:48
With this extension all influxdb columns (beside of
time and sequence_number) will be available in Graphite.
This allows to use timeseries automaticaly calculated by
continuous queries, where the column name is named after
the group by function, e.g. sum, mean.

The column-name is separated by the constant string which is
configurable in the config-file. This string enables the possibitity
to identify leafs and therefore to shortcut in case of rendering a
graph. This may be replaced by caching in the finder.
Provide functional compatibility to whisper db, where missing
values generate None (null).
Without filling the gaps, Graphite-Web is generating wrong graphics.
@torkelo
Copy link

torkelo commented Jun 11, 2014

How do you know the step interval? When there is no retention (schema) config. I guess the step interval depends on the time range? I havent looked at the code but did try to fill in missing steps in grafana recently and it was tricky as I do not know the the rate of measurements so what is a missing step?

In graphite we know if there is a measurement missing but not with influxdb. Lets say you input data every 10 seconds, and look at only 10min range what will the step interval be then? If the step interval is below 10seconds then nulls will be inserted between every measurement.

@Dieterbe
Copy link
Contributor

torkelo you're exactly right. we were getting the step as timedelta(2ndpoint-1stpoint) but as I found out yesterday, this didn't work in case of missing values, so i pushed this fix 35e0ad7

we basically need a source of truth, like carbon has storage-schemas.conf ; for now it's hardcoded in graphite-influxdb but at some point i'ld like this info to be available in influx and then we'd just query influx

@Dieterbe
Copy link
Contributor

I cherrypicked the Fill missing values (within the step interval) with None values … e7729db , as well as Rene's commit. Not the middle one as described in #4

@Dieterbe Dieterbe closed this Jun 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants