-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature influx values (support for columns other than value) #4
Conversation
With this extension all influxdb columns (beside of time and sequence_number) will be available in Graphite. This allows to use timeseries automaticaly calculated by continuous queries, where the column name is named after the group by function, e.g. sum, mean. The column-name is separated by the constant string which is configurable in the config-file. This string enables the possibitity to identify leafs and therefore to shortcut in case of rendering a graph. This may be replaced by caching in the finder.
Nice. I used structlog in my modifications because that's what I usually use but I think standard logging is more what people will expect. To switch to standard logging, replace the import and the get_logger call with: import logging
logger = logging.getLogger(__name__) And then when logging messages, do For the record, here's a logging config for graphite-api that lets you see log messages: logging:
version: 1
disable_existing_loggers: true
handlers:
stdout:
class: logging.StreamHandler
loggers:
graphite_api:
handlers:
- stdout
propagate: true
level: DEBUG
graphite_influxdb:
handlers:
- stdout
propagate: true
level: DEBUG |
i applied the first commit, but with the 2nd enabled the code basically does:
this is slow and my gunicorn workers just timeout. also the 2nd patch would require a documentation update |
Fine for me. I wasn't happy with the performance as well. |
actually @breml to do this thing, we only need to get the list of columns right? |
closing due to inactivity |
I extendet the good work of @Dieterbe and @brutasse with the possibility to fetch not only the column value but every column. This is especial useful if one uses continuous queries where columns are named after the group by function (e.g. sum, mean).