Add abort-to-latin and abort-to-latin-unhandled command
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lo48576
force-pushed
the
feature/add-abort-to-latin-commands
branch
from
429f933
to
b77fed7
Compare
lo48576
changed the title
abort-to-latin and abort-to-latin-passthrough commandabort-to-latin and abort-to-latin-passthrough command
lo48576
force-pushed
the
feature/add-abort-to-latin-commands
branch
from
b77fed7
to
cee92fc
Compare
lo48576
changed the title
abort-to-latin and abort-to-latin-passthrough commandabort-to-latin and abort-to-latin-passthrough command
ueno
requested changes
Jan 22, 2018
libskk/state.vala
Outdated
| bool retval; | ||
| if (command == "abort" || | ||
| command == "abort-to-latin" || | ||
| command == "abort-to-latin-passthrough") { |
There was a problem hiding this comment.
There is commit-unhandled where -unhandled means the same thing as -passthrough here. I rather like the latter, though.
lo48576
force-pushed
the
feature/add-abort-to-latin-commands
branch
from
cee92fc
to
f656399
Compare
lo48576
pushed a commit
to lo48576/libskk
that referenced
this pull request
Jan 22, 2018
* Renamed `abort-to-latin-passthrough` command to
`abort-to-latin-unhandled`
* Renamed a variable `allow_passthrough` to `event_handled`.
Note that they use inverse values to represent states,
i.e. "event is handled" means "passthrough is *NOT* allowed",
and vice versa.
See <ueno#48 (comment)>.
I'm going to write a test. |
|
I realized that I can't write complete tests because of #49 (it prevents me from using custom rule during dict edit)... orz |
added 3 commits
January 23, 2018 02:11
This change and PR ueno#47 (`Escape` keymap) enables us to use "vi-cooperative" keymap. `abort-to-latin` does "`abort`, then change to latin input mode". If the state changes on abort or mode change, key event is consumed. `abort-to-latin-passthrough` does "`abort`, then change to latin input mode, and let key event pass-through when no input string is discarded". "vi-cooperative" keymap will be achived by config such as the code below: ```json { "include": [ "default" ], "define": { "keymap": { "Escape": "abort-to-latin-passthrough", } } } ``` `abort-to-latin-passthrough` does not consume the key event even if the state changed. So, when the user type "C-j Esc" under the config above, application will receive "Esc" key event, in contrast to `abort-to-latin` command.
* Renamed `abort-to-latin-passthrough` command to
`abort-to-latin-unhandled`
* Renamed a variable `allow_passthrough` to `event_handled`.
Note that they use inverse values to represent states,
i.e. "event is handled" means "passthrough is *NOT* allowed",
and vice versa.
See <ueno#48 (comment)>.
lo48576
force-pushed
the
feature/add-abort-to-latin-commands
branch
from
f656399
to
1495c4e
Compare
|
Added tests, but they can't (or I don't know how to) represent "unhandled" key event behaviour. |
lo48576
changed the title
abort-to-latin and abort-to-latin-passthrough commandabort-to-latin and abort-to-latin-unhandled command
ueno
approved these changes
Jan 23, 2018
ueno
pushed a commit
that referenced
this pull request
Jan 23, 2018
* Renamed `abort-to-latin-passthrough` command to
`abort-to-latin-unhandled`
* Renamed a variable `allow_passthrough` to `event_handled`.
Note that they use inverse values to represent states,
i.e. "event is handled" means "passthrough is *NOT* allowed",
and vice versa.
See <#48 (comment)>.
|
OK, I will adjust the test later; thanks anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change and PR #47 (
Escapekeymap) enables us to use"vi-cooperative" keymap.
abort-to-latindoes "abort, then change to latin input mode".If the state changes on abort or mode change, key event is consumed.
abort-to-latin-unhandleddoes "abort, then change to latin inputmode, and let key event pass-through when no input string is discarded".
"vi-cooperative" keymap will be achived by config such as the code below:
{ "include": [ "default" ], "define": { "keymap": { "Escape": "abort-to-latin-unhandled", } } }abort-to-latin-unhandleddoes not consume the key event even if thestate changed.
So, when the user type "C-j Esc" under the config above, application
will receive "Esc" key event, in contrast to
abort-to-latincommand.