Add Escape, Henkan, Muhenkan keyval names
#47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lo48576
pushed a commit
to lo48576/libskk
that referenced
this pull request
Jan 20, 2018
This change and PR ueno#47 (`Escape` keymap) enables us to use "vi-cooperative" keymap. `abort-to-latin` does "`abort`, then change to latin input mode". If the state changes on abort or mode change, key event is consumed. `abort-to-latin-passthrough` does "`abort`, then change to latin input mode, and let key event pass-through". "vi-cooperative" keymap will be achived by config such as the code below: ```json { "include": [ "default" ], "define": { "keymap": { "Escape": "abort-to-latin-passthrough", } } } ``` `abort-to-latin-passthrough` does not consume the key event even if the state changed. So, when the user type "C-j Esc" under the config above, application will receive "Esc" key event, in contrast to `abort-to-latin` command.
lo48576
pushed a commit
to lo48576/libskk
that referenced
this pull request
Jan 20, 2018
This change and PR ueno#47 (`Escape` keymap) enables us to use "vi-cooperative" keymap. `abort-to-latin` does "`abort`, then change to latin input mode". If the state changes on abort or mode change, key event is consumed. `abort-to-latin-passthrough` does "`abort`, then change to latin input mode, and let key event pass-through". "vi-cooperative" keymap will be achived by config such as the code below: ```json { "include": [ "default" ], "define": { "keymap": { "Escape": "abort-to-latin-passthrough", } } } ``` `abort-to-latin-passthrough` does not consume the key event even if the state changed. So, when the user type "C-j Esc" under the config above, application will receive "Esc" key event, in contrast to `abort-to-latin` command.
lo48576
changed the title
Escape keyval nameEscape, Henkan, Muhenkan keyval names
|
Add names |
ueno
approved these changes
Jan 22, 2018
There was a problem hiding this comment.
The change itself looks good, though we would need to find a way to map these keysyms to lshift/rshift for NICOLA. Also, for the long run, it might make more sense to switch to using binary search on the keysym table provided by libxkbcommon:
ueno/libkkc@0bfe596
lo48576
pushed a commit
to lo48576/libskk
that referenced
this pull request
Jan 22, 2018
This change and PR ueno#47 (`Escape` keymap) enables us to use "vi-cooperative" keymap. `abort-to-latin` does "`abort`, then change to latin input mode". If the state changes on abort or mode change, key event is consumed. `abort-to-latin-passthrough` does "`abort`, then change to latin input mode, and let key event pass-through". "vi-cooperative" keymap will be achived by config such as the code below: ```json { "include": [ "default" ], "define": { "keymap": { "Escape": "abort-to-latin-passthrough", } } } ``` `abort-to-latin-passthrough` does not consume the key event even if the state changed. So, when the user type "C-j Esc" under the config above, application will receive "Esc" key event, in contrast to `abort-to-latin` command.
lo48576
pushed a commit
to lo48576/libskk
that referenced
this pull request
Jan 22, 2018
This change and PR ueno#47 (`Escape` keymap) enables us to use "vi-cooperative" keymap. `abort-to-latin` does "`abort`, then change to latin input mode". If the state changes on abort or mode change, key event is consumed. `abort-to-latin-passthrough` does "`abort`, then change to latin input mode, and let key event pass-through when no input string is discarded". "vi-cooperative" keymap will be achived by config such as the code below: ```json { "include": [ "default" ], "define": { "keymap": { "Escape": "abort-to-latin-passthrough", } } } ``` `abort-to-latin-passthrough` does not consume the key event even if the state changed. So, when the user type "C-j Esc" under the config above, application will receive "Esc" key event, in contrast to `abort-to-latin` command.
lo48576
pushed a commit
to lo48576/libskk
that referenced
this pull request
Jan 22, 2018
This change and PR ueno#47 (`Escape` keymap) enables us to use "vi-cooperative" keymap. `abort-to-latin` does "`abort`, then change to latin input mode". If the state changes on abort or mode change, key event is consumed. `abort-to-latin-passthrough` does "`abort`, then change to latin input mode, and let key event pass-through when no input string is discarded". "vi-cooperative" keymap will be achived by config such as the code below: ```json { "include": [ "default" ], "define": { "keymap": { "Escape": "abort-to-latin-passthrough", } } } ``` `abort-to-latin-passthrough` does not consume the key event even if the state changed. So, when the user type "C-j Esc" under the config above, application will receive "Esc" key event, in contrast to `abort-to-latin` command.
|
So, at this time (in this PR), b543ed1 (lshift/rshift rename) should be reverted (or resetted)? |
added 4 commits
January 23, 2018 02:40
By this change, "Escape" can be used to represent escape key in keymap rules.
This will solve the issue ueno#38.
…shift`" This reverts commit b543ed1. NICOLA wants "lshift" and "rshift" keysyms. See <ueno#47 (review)> for detail.
By this way, "lshift" and "rshift" keyval names are preserved, and "Muhenkan" and "Henkan" can be used in typing rules config.
lo48576
force-pushed
the
feature/enable-escape-keymap
branch
from
b543ed1
to
75648cf
Compare
|
Reverted the change of keysyms mapping, and added (temporary) workaround. This logic is (currently) only used to load keymap rules and to emulate key sequences by string, |
ueno
pushed a commit
that referenced
this pull request
Jan 23, 2018
This change and PR #47 (`Escape` keymap) enables us to use "vi-cooperative" keymap. `abort-to-latin` does "`abort`, then change to latin input mode". If the state changes on abort or mode change, key event is consumed. `abort-to-latin-passthrough` does "`abort`, then change to latin input mode, and let key event pass-through when no input string is discarded". "vi-cooperative" keymap will be achived by config such as the code below: ```json { "include": [ "default" ], "define": { "keymap": { "Escape": "abort-to-latin-passthrough", } } } ``` `abort-to-latin-passthrough` does not consume the key event even if the state changed. So, when the user type "C-j Esc" under the config above, application will receive "Esc" key event, in contrast to `abort-to-latin` command.
|
#54 is merged and it enables the keys to be mapped, so closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By this change, "Escape" can be used to represent escape key in keymap rules.