fix(radio): set aria-required on radio group element instead of individual radios #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrichardsontylertech
added
patch
|
|
DRiFTy17
reviewed
May 31, 2024
DRiFTy17
approved these changes
May 31, 2024
|
🚀 PR was released in |
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
A radio no longer sets
aria-requiredon itself. Instead, when the state ofrequiredchanges the required status of each radio in the group is evaluated andaria-requiredset on the closestfieldset, element withrole=radiogroup, orforge-radio-group. The Forge radio group component attempts the same logic when it's added to the DOM.