Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add className handling to header and footer subcomponents #735

Merged
merged 3 commits into from
Dec 28, 2020
Merged

fix: Add className handling to header and footer subcomponents #735

merged 3 commits into from
Dec 28, 2020

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Dec 22, 2020 •
edited
Loading

Summary

Add className prop and tests for custom classes on small subcomponents.

Related Issues or PRs

resolves #488

How To Test

Happo should pass

@haworku haworku added the type: bug Something isn't working like it's supposed to label Dec 22, 2020
@trussworks-infra-zz
Copy link

trussworks-infra-zz commented Dec 22, 2020 •
edited
Loading

Warnings
⚠️ This PR does not include changes to storybook, even though it affects component code.

Generated by 🚫 dangerJS against 70cb868

@haworku haworku self-assigned this Dec 22, 2020
ahobson
ahobson approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@ahobson ahobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haworku haworku merged commit 808b290 into main Dec 28, 2020
@haworku haworku deleted the hw-subcomponent-styles-488 branch December 28, 2020 16:06
@haworku haworku mentioned this pull request Dec 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahobson ahobson ahobson approved these changes

@gidjin gidjin Awaiting requested review from gidjin

@sarboc sarboc Awaiting requested review from sarboc

@suzubara suzubara Awaiting requested review from suzubara

@tinyels tinyels Awaiting requested review from tinyels

Assignees

@haworku haworku

Labels
type: bug Something isn't working like it's supposed to
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] Make subcomponents handle styles passed in by consumer
3 participants
@haworku @trussworks-infra-zz @ahobson