Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Downgrade.yml #105

Merged
merged 8 commits into from
Jan 26, 2024
Merged

Create Downgrade.yml #105

merged 8 commits into from
Jan 26, 2024

Conversation

JoshuaLampert
Copy link
Member

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21de330) 17.64% compared to head (eb28109) 17.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   17.64%   17.64%           
=======================================
  Files           3        3           
  Lines        1423     1423           
=======================================
  Hits          251      251           
  Misses       1172     1172           
Flag Coverage Δ
unittests 17.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaLampert
Copy link
Member Author

JoshuaLampert commented Dec 13, 2023

There is a bug in the GitHub action that lets the action fail if a package name contains an underscore (here P4est_jll), see cjdoris/julia-downgrade-compat-action#2.

@JoshuaLampert
Copy link
Member Author

The GitHub action is fixed now and in principle it works with the newest version. I've set the lower compat bounds to the lowest possible such that after downgrading the tests still pass.
However, it seems that - uses: cjdoris/julia-downgrade-compat-action@v1 doesn't recognize the newest version v1.0.7 of the GitHub action although it's already released. Explicitly stating - uses: cjdoris/julia-downgrade-compat-action@v1.0.7 fixes the version, but I'd rather not like to specify the exact version. Usually, @v1 should take the latest release, shouldn't it @ranocha?

@ranocha
Copy link
Member

ranocha commented Jan 26, 2024

Looks like GitHub is doing weird stuff here, see https://devopsjournal.io/blog/2022/10/19/How-GitHub-Actions-versioning-works

The @vXYZ specification makes it look at a tag vXYZ in the repo. The tag v1 in the repo points to an old version, see https://github.com/cjdoris/julia-downgrade-compat-action/tags
The maintainer has to update the tag manually to make it work as you (and I) would expect. Thus, it's fine to use julia-downgrade-compat-action@v1.0.7 explicitly.

@JoshuaLampert
Copy link
Member Author

Ok, I set the version back to v1.0.7.

@JoshuaLampert JoshuaLampert enabled auto-merge (squash) January 26, 2024 10:59
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert JoshuaLampert merged commit d8f9add into main Jan 26, 2024
16 checks passed
@JoshuaLampert JoshuaLampert deleted the downgrade-yml branch January 26, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants