Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Downgrade.yml #50

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Create Downgrade.yml #50

merged 4 commits into from
Feb 2, 2024

Conversation

JoshuaLampert
Copy link
Collaborator

@JoshuaLampert JoshuaLampert marked this pull request as ready for review January 26, 2024 14:03
ranocha
ranocha approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert
Copy link
Collaborator Author

JoshuaLampert commented Jan 26, 2024 •
edited
Loading

I fixed the lower compat bounds such that the Downgrade action passes. In addition, I cleaned up the Project.toml a bit, i.e.:

  1. I added compat bounds for stdlibs (Libdl, UUIDs, Test) as recommended in https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing.
  2. I removed TOML from the Project.toml since it is not used in T8code.jl.

@JoshuaLampert
Copy link
Collaborator Author

Ok to merge, @jmark?

@ranocha ranocha requested a review from jmark January 29, 2024 14:00
@jmark jmark merged commit 2b5c0bf into DLR-AMR:main Feb 2, 2024
14 checks passed
@JoshuaLampert JoshuaLampert deleted the downgrade-yml branch February 2, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranocha ranocha ranocha approved these changes

@jmark jmark Awaiting requested review from jmark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaLampert @ranocha @jmark