Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainer application #640

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Aug 29, 2022

I'm a maintainer of several other services often related to the Kuberenetes back-end/Kubernetes controllers and I'm taking ownership for a lot of release synchronization making it both appropriate and necessary for me to maintain aspects of the Tink repository.

Requirements:

Here is a list of non-trival PRs I have been the primary reviewer on:

#596
#628
#614

I have also made a number of code contributions to this repository, here are a few of them:

#638
#631
#626
#622
#612

I have also raised various issues and am driving the releasing across Tinkerbell including in this repository.

Requesting consideration of expedited responsibilities: yes

Sponsors:

Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #640 (5f73161) into main (ed90557) will not change coverage.
The diff coverage is n/a.

❗ Current head 5f73161 differs from pull request most recent head 4b6ac62. Consider uploading reports for the commit 4b6ac62 to get more accurate results

@@           Coverage Diff           @@
##             main     #640   +/-   ##
=======================================
  Coverage   45.07%   45.07%           
=======================================
  Files          62       62           
  Lines        3554     3554           
=======================================
  Hits         1602     1602           
  Misses       1870     1870           
  Partials       82       82           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for being willing!

@chrisdoherty4 chrisdoherty4 changed the title Make chrisdoherty4 a maintainer Maintainer application Aug 29, 2022
@jacobweinstock
Copy link
Member

I'm not a maintainer in this repo but as a Tinkerbell org Admin I am on board with this as a fast track request. Thanks Chris!

Copy link
Contributor

@mmlb mmlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Aug 29, 2022
@mergify mergify bot merged commit eeb2a45 into tinkerbell:main Aug 29, 2022
@chrisdoherty4 chrisdoherty4 deleted the org/maintainer branch May 15, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants