-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintainer application #640
Conversation
Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
60f5610
to
4b6ac62
Compare
Codecov Report
@@ Coverage Diff @@
## main #640 +/- ##
=======================================
Coverage 45.07% 45.07%
=======================================
Files 62 62
Lines 3554 3554
=======================================
Hits 1602 1602
Misses 1870 1870
Partials 82 82 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for being willing!
I'm not a maintainer in this repo but as a Tinkerbell org Admin I am on board with this as a fast track request. Thanks Chris! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
I'm a maintainer of several other services often related to the Kuberenetes back-end/Kubernetes controllers and I'm taking ownership for a lot of release synchronization making it both appropriate and necessary for me to maintain aspects of the Tink repository.
Requirements:
Here is a list of non-trival PRs I have been the primary reviewer on:
#596
#628
#614
I have also made a number of code contributions to this repository, here are a few of them:
#638
#631
#626
#622
#612
I have also raised various issues and am driving the releasing across Tinkerbell including in this repository.
Requesting consideration of expedited responsibilities: yes
Sponsors: