Validate mac address on Hardware spec: #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
=======================================
Coverage 44.52% 44.52%
=======================================
Files 61 61
Lines 3519 3519
=======================================
Hits 1567 1567
Misses 1870 1870
Partials 82 82
Continue to review full report at Codecov.
|
jacobweinstock
force-pushed
the
validate-mac
branch
3 times, most recently
from
74c4b97
to
dfa33fc
Compare
This only allows lower case mac addresses. This simplifies matching/looking up mac addresses. Without this values could be upper case or mixed case. Upper case and mixed cases will cause clients to miss lookups if using the wrong case. This standardized to lowercase to remove this error prone interaction. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
validate-mac
branch
from
dfa33fc
to
733e536
Compare
chrisdoherty4
approved these changes
Jun 14, 2022
Merged
mergify bot
added a commit
that referenced
this pull request
Aug 29, 2022
I'm a maintainer of several other services often related to the Kuberenetes back-end/Kubernetes controllers and I'm taking ownership for a lot of release synchronization making it both appropriate and necessary for me to maintain aspects of the Tink repository. Requirements: - I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md) - I have [enabled 2FA on my GitHub account](https://github.com/settings/security) - I have subscribed to the [tinkerbell-contributors e-mail list](https://groups.google.com/g/tinkerbell-contributors) - I am actively contributing to 1 or more Tinkerbell subprojects Here is a list of non-trival PRs I have been the primary reviewer on: #596 #628 #614 I have also made a number of code contributions to this repository, here are a few of them: #638 #631 #626 #622 #612 I have also raised various issues and am driving the releasing across Tinkerbell including in this repository. Requesting consideration of expedited responsibilities: yes Sponsors: - @mmlb (Maintainer) - @micahhausler (Maintainer) - @jacobweinstock (Core contributor in other Tinkerbell repositories)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This only allows lower case mac addresses. This simplifies matching/looking up mac addresses. Without this values could be upper case or mixed case. Upper case and mixed cases will cause clients to miss lookups if using the wrong case. This standardized to lowercase to remove this error prone interaction.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: