Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.2.1 #3167

Merged
merged 1 commit into from
May 5, 2021
Merged

Release 2.2.1 #3167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 28 additions & 9 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,24 +6,43 @@ accidentally triggering the load of a previous DB version.**

## Unreleased

## 2.2.1 (2021-05-05)

This maintenance release contains bugfixes since the 2.2.0 release. We
deem it high priority for upgrading.

This release extends Skip Scan to multinode by enabling the pushdown
of `DISTINCT` to data nodes. It also fixes a number of bugs in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are also bugfixes for multinode, compression, when creating indexes concurrently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you be more specific?

These are the commits that are already in the release branch:

$ git log --no-decorate --oneline 2.2.0..
7f81c64e Add a few miscellaneous code fixes
3a6bd974 Add changelog entry for #3169
fd7d1d70 Fix incorrect type cast in compression policy
b4e1610c Use no-unused-command-line-argument flag
8d3951fa Add coredump support for 32bit ci runs
d5f17556 Inherit CFLAGS from postgresql
b470dad9 Fix fdw_relinfo_get assertion failure on DELETE
b92b1af6 Copy recreated object permissions on update
20459fe1 Fix flaky dist_hypertable test
e0fc2bf5 Add GitHub action for posting daily CI summary
6f422a5d Fix use after free in cache
6977de02 Remove slack notification from individual workflows
fe1fc4af Add update smoke test script
26a7752e Make SELECT DISTINCT handle non-var targetlists
f3bbde8c Skip ChunkAppend if AppendPath has no children
def6534d Fix SkipScan for IndexPaths without pathkeys
45f1b2e2 Fix flaky pg_dump test
ba41b562 Run code style regression test on all PRs
f454522d Ignore generated SQL test files from templates
3b1582c6 Add "SELECT DISTINCT" pushdown in multi-node
753ebcb6 Increase number of connections for tsl tests
2c645b6d Fix SkipScan path generation with expressions
84b945b1 Fix REINDEX TABLE for distributed hypertables
3600c066 Fix crash while using REINDEX TABLE CONCURRENTLY
973e37c1 Fix windows CI PG13 failure
8c7bd485 Use %u to format Oid instead of %d
063daa15 Move plan nodes to nodes subdirectory
5a59ba7b Fix use after free in chunk_api_get_chunk_stats
1b8b97df Fix use after free in add_reorder_policy
776efc4a Fix CMAKE_BUILD_TYPE check
6ad8a2b9 Use commit date in get_git_commit()

These are the ones that are in master and not in the release branch:

$ git log --format=format:"%h %s" --cherry-pick --left-only --no-merges upstream/master...HEAD
04328b51 Fix spelling error in time_bucket error message
1499ed4f Add function to set chunk status
e0bff859 Add chunk_status column to catalog chunk table
aeb10765 Copy recreated object permissions on update
baaa9abd Add 2.2.0 to update test scripts
b1143de7 Release 2.2.0

Copy link
Contributor Author

@mkindahl mkindahl May 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that you mean the wording in that particular paragraph, not that any commits are missing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it was about the wording we usually give a summary of the areas affected by the bugfixes

implementation of Skip Scan, in distributed hypertables, in creation
of indexes, in compression, and in policies.

**Features**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super-important, and more of a nit: IMO this is a "fix" or a "performance" enhancement rather than a "feature". There's no "new" functionality introduced that changes capabilities. There's a lot of stuff that we can optimize in queries, especially when it comes to pushing things down to data nodes. I don't think all such enhancements are features.

Wondering if we should start adding a section for "Performance enhancement" or similar. Fine to do this for later too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it is a fix or enhancement, I think it is worth to highlight. Reworded it slightly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

distinct pushdown is a new feature

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is listed under "features".

* #3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan
* #3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip
Scan

**Bugfixes**
* #3101 Use commit date in get_git_commit()
* #3104 Fix use after free in add_reorder_policy
* #3106 Fix use after free in chunk_api_get_chunk_stats
* #3123 Fix crash while using REINDEX TABLE CONCURRENTLY
* #3135 Fix SkipScan path generation in DISTINCT queries with expressions
* #3101 Use commit date in `get_git_commit()`
* #3102 Fix `REINDEX TABLE` for distributed hypertables
* #3104 Fix use after free in `add_reorder_policy`
* #3106 Fix use after free in `chunk_api_get_chunk_stats`
* #3109 Copy recreated object permissions on update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to your lists of commits not in this release #3109 is not part of 2.2.1 and should be in the unreleased section instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is actually an issue with what git shows. For some reason, it shows it both as merged and not merged:

$ git log --format=format:"%h %s" --cherry-pick --left-only --no-merges upstream/master...HEAD
04328b51 Fix spelling error in time_bucket error message
1499ed4f Add function to set chunk status
e0bff859 Add chunk_status column to catalog chunk table
aeb10765 Copy recreated object permissions on update
baaa9abd Add 2.2.0 to update test scripts
b1143de7 Release 2.2.0
$ git log --no-decorate --oneline 2.2.0.. | grep Copy
b92b1af6 Copy recreated object permissions on update
$ git branch
  2.2.x
  master
  release-2.2.1
* release-2.2.x
$ git log --no-decorate --oneline 2.2.0.. | grep Copy
b92b1af6 Copy recreated object permissions on update
$ git cherry-pick aeb10765
Auto-merging scripts/test_updates_pg12.sh
Auto-merging scripts/test_updates_pg11.sh
On branch release-2.2.x
Your branch is up to date with 'origin/release-2.2.x'.

You are currently cherry-picking commit aeb10765.
  (all conflicts fixed: run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        build-12/
        sql/updates/2.2.0--2.2.1.sql
        update_test.restored.diff.2.2.0-pg11

nothing added to commit but untracked files present (use "git add" to track)
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
$ git cherry-pick --skip

* #3111 Fix `CMAKE_BUILD_TYPE` check
* #3112 Use `%u` to format Oid instead of `%d`
* #3118 Fix use after free in cache
* #3123 Fix crash while using `REINDEX TABLE CONCURRENTLY`
* #3135 Fix SkipScan path generation in `DISTINCT` queries with expressions
* #3146 Fix SkipScan for IndexPaths without pathkeys
* #3151 Fix fdw_relinfo_get assertion failure on DELETE
* #3155 Inherit CFLAGS from PostgreSQL
* #3147 Skip ChunkAppend if AppendPath has no children
* #3148 Make `SELECT DISTINCT` handle non-var targetlists
* #3151 Fix `fdw_relinfo_get` assertion failure on `DELETE`
* #3155 Inherit `CFLAGS` from PostgreSQL
* #3169 Fix incorrect type cast in compression policy
* #3183 Fix segfault in calculate_chunk_interval
* #3185 Fix wrong datatype for integer based retention policy

**Thanks**
* @aelg for reporting an issue with policies on integer-based hypertables
* @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views
* @aelg for reporting an issue with policies on integer-based hypertables
* @hperez75 for reporting an issue with Skip Scan
* @nathanloisel for reporting an issue with compression on hypertables with integer-based timestamps
* @xin-hedera for fixing an issue with compression on hypertables with integer-based timestamps
Expand Down
1 change: 1 addition & 0 deletions sql/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ set(MOD_FILES
updates/2.0.2--2.1.0.sql
updates/2.1.0--2.1.1.sql
updates/2.1.1--2.2.0.sql
updates/2.2.0--2.2.1.sql
)

set(MODULE_PATHNAME "$libdir/timescaledb-${PROJECT_VERSION_MOD}")
Expand Down
2 changes: 1 addition & 1 deletion version.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
version = 2.3.0-dev
update_from_version = 2.2.0
update_from_version = 2.2.1