Release 2.2.1 #3167
Merged
Release 2.2.1 #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3167 +/- ##
==========================================
+ Coverage 90.17% 90.30% +0.12%
==========================================
Files 215 215
Lines 35389 35341 -48
==========================================
+ Hits 31912 31914 +2
+ Misses 3477 3427 -50
Continue to review full report at Codecov.
|
mkindahl
force-pushed
the
release-2.2.1
branch
2 times, most recently
from
a7489fd
to
5287eb5
Compare
erimatnor
reviewed
Apr 29, 2021
| This release adds support for Skip Scan on multinode by enabling the | ||
| pushdown of `DISTINCT` to data nodes and also fixes a number of bugs | ||
| in the implementation of Skip Scan. | ||
|
|
||
| **Features** |
There was a problem hiding this comment.
Not super-important, and more of a nit: IMO this is a "fix" or a "performance" enhancement rather than a "feature". There's no "new" functionality introduced that changes capabilities. There's a lot of stuff that we can optimize in queries, especially when it comes to pushing things down to data nodes. I don't think all such enhancements are features.
Wondering if we should start adding a section for "Performance enhancement" or similar. Fine to do this for later too.
There was a problem hiding this comment.
Even though it is a fix or enhancement, I think it is worth to highlight. Reworded it slightly.
There was a problem hiding this comment.
distinct pushdown is a new feature
There was a problem hiding this comment.
It is listed under "features".
version.config
Outdated
| @@ -1,2 +1,2 @@ | |||
| version = 2.3.0-dev | |||
| update_from_version = 2.2.0 | |||
| version = 2.4.0-dev | |||
There was a problem hiding this comment.
I don't think we are doing this bump for a patch release, right? We are still on 2.3.0-dev since we're releasing 2.2.1.
erimatnor
approved these changes
May 3, 2021
svenklemm
requested changes
May 3, 2021
svenklemm
reviewed
May 3, 2021
| deem it high priority for upgrading. | ||
|
|
||
| This release extends Skip Scan to multinode by enabling the pushdown | ||
| of `DISTINCT` to data nodes. It also fixes a number of bugs in the |
There was a problem hiding this comment.
there are also bugfixes for multinode, compression, when creating indexes concurrently
There was a problem hiding this comment.
Could you be more specific?
These are the commits that are already in the release branch:
$ git log --no-decorate --oneline 2.2.0..
7f81c64e Add a few miscellaneous code fixes
3a6bd974 Add changelog entry for #3169
fd7d1d70 Fix incorrect type cast in compression policy
b4e1610c Use no-unused-command-line-argument flag
8d3951fa Add coredump support for 32bit ci runs
d5f17556 Inherit CFLAGS from postgresql
b470dad9 Fix fdw_relinfo_get assertion failure on DELETE
b92b1af6 Copy recreated object permissions on update
20459fe1 Fix flaky dist_hypertable test
e0fc2bf5 Add GitHub action for posting daily CI summary
6f422a5d Fix use after free in cache
6977de02 Remove slack notification from individual workflows
fe1fc4af Add update smoke test script
26a7752e Make SELECT DISTINCT handle non-var targetlists
f3bbde8c Skip ChunkAppend if AppendPath has no children
def6534d Fix SkipScan for IndexPaths without pathkeys
45f1b2e2 Fix flaky pg_dump test
ba41b562 Run code style regression test on all PRs
f454522d Ignore generated SQL test files from templates
3b1582c6 Add "SELECT DISTINCT" pushdown in multi-node
753ebcb6 Increase number of connections for tsl tests
2c645b6d Fix SkipScan path generation with expressions
84b945b1 Fix REINDEX TABLE for distributed hypertables
3600c066 Fix crash while using REINDEX TABLE CONCURRENTLY
973e37c1 Fix windows CI PG13 failure
8c7bd485 Use %u to format Oid instead of %d
063daa15 Move plan nodes to nodes subdirectory
5a59ba7b Fix use after free in chunk_api_get_chunk_stats
1b8b97df Fix use after free in add_reorder_policy
776efc4a Fix CMAKE_BUILD_TYPE check
6ad8a2b9 Use commit date in get_git_commit()
These are the ones that are in master and not in the release branch:
$ git log --format=format:"%h %s" --cherry-pick --left-only --no-merges upstream/master...HEAD
04328b51 Fix spelling error in time_bucket error message
1499ed4f Add function to set chunk status
e0bff859 Add chunk_status column to catalog chunk table
aeb10765 Copy recreated object permissions on update
baaa9abd Add 2.2.0 to update test scripts
b1143de7 Release 2.2.0
There was a problem hiding this comment.
I assume that you mean the wording in that particular paragraph, not that any commits are missing.
There was a problem hiding this comment.
yes it was about the wording we usually give a summary of the areas affected by the bugfixes
svenklemm
reviewed
May 3, 2021
CHANGELOG.md
Outdated
Comment on lines
23
to
39
| * #3101 Use commit date in `get_git_commit()` | ||
| * #3104 Fix use after free in `add_reorder_policy` | ||
| * #3106 Fix use after free in `chunk_api_get_chunk_stats` | ||
| * #3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` | ||
| * #3135 Fix SkipScan path generation in `DISTINCT` queries with | ||
| expressions | ||
| * #3146 Fix SkipScan for IndexPaths without pathkeys | ||
| * #3151 Fix fdw_relinfo_get assertion failure on DELETE | ||
| * #3151 Fix `fdw_relinfo_get` assertion failure on DELETE | ||
| * #3155 Inherit CFLAGS from PostgreSQL | ||
| * #3169 Fix incorrect type cast in compression policy | ||
| * #3109 Copy recreated object permissions on update | ||
| * #3148 Make `SELECT DISTINCT` handle non-var targetlists | ||
| * #3147 Skip ChunkAppend if AppendPath has no children | ||
| * #3102 Fix REINDEX TABLE for distributed hypertables | ||
| * #3118 Fix use after free in cache | ||
| * #3112 Use `%u` to format Oid instead of `%d` | ||
| * #3111 Fix `CMAKE_BUILD_TYPE` check | ||
| * #3169 Fix incorrect type cast in compression policy |
mkindahl
force-pushed
the
release-2.2.1
branch
2 times, most recently
from
02f173f
to
cd69908
Compare
NunoFilipeSantos
approved these changes
May 4, 2021
Done. |
svenklemm
reviewed
May 4, 2021
| * #3102 Fix `REINDEX TABLE` for distributed hypertables | ||
| * #3104 Fix use after free in `add_reorder_policy` | ||
| * #3106 Fix use after free in `chunk_api_get_chunk_stats` | ||
| * #3109 Copy recreated object permissions on update |
There was a problem hiding this comment.
according to your lists of commits not in this release #3109 is not part of 2.2.1 and should be in the unreleased section instead
There was a problem hiding this comment.
That is actually an issue with what git shows. For some reason, it shows it both as merged and not merged:
$ git log --format=format:"%h %s" --cherry-pick --left-only --no-merges upstream/master...HEAD
04328b51 Fix spelling error in time_bucket error message
1499ed4f Add function to set chunk status
e0bff859 Add chunk_status column to catalog chunk table
aeb10765 Copy recreated object permissions on update
baaa9abd Add 2.2.0 to update test scripts
b1143de7 Release 2.2.0
$ git log --no-decorate --oneline 2.2.0.. | grep Copy
b92b1af6 Copy recreated object permissions on update
$ git branch
2.2.x
master
release-2.2.1
* release-2.2.x
$ git log --no-decorate --oneline 2.2.0.. | grep Copy
b92b1af6 Copy recreated object permissions on update
$ git cherry-pick aeb10765
Auto-merging scripts/test_updates_pg12.sh
Auto-merging scripts/test_updates_pg11.sh
On branch release-2.2.x
Your branch is up to date with 'origin/release-2.2.x'.
You are currently cherry-picking commit aeb10765.
(all conflicts fixed: run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Untracked files:
(use "git add <file>..." to include in what will be committed)
build-12/
sql/updates/2.2.0--2.2.1.sql
update_test.restored.diff.2.2.0-pg11
nothing added to commit but untracked files present (use "git add" to track)
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:
git commit --allow-empty
Otherwise, please use 'git cherry-pick --skip'
$ git cherry-pick --skip
mfreed
approved these changes
May 4, 2021
CHANGELOG.md
Outdated
| @@ -6,25 +6,45 @@ accidentally triggering the load of a previous DB version.** | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ## 2.2.1 (2021-05-05) | |||
|
|
|||
| This maintenance release contains bugfixes since the 2.1.0 release. We | |||
There was a problem hiding this comment.
Suggested change
| This maintenance release contains bugfixes since the 2.1.0 release. We | |
| This maintenance release contains bugfixes since the 2.2.0 release. We |
svenklemm
approved these changes
May 4, 2021
This maintenance release contains bugfixes since the 2.2.0 release. We deem it high priority for upgrading. This release extends Skip Scan to multinode by enabling the pushdown of `DISTINCT` to data nodes. It also fixes a number of bugs in the implementation of Skip Scan, in distributed hypertables, in creation of indexes, in compression, and in policies. **Features** * timescale#3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan **Bugfixes** * timescale#3101 Use commit date in `get_git_commit()` * timescale#3102 Fix `REINDEX TABLE` for distributed hypertables * timescale#3104 Fix use after free in `add_reorder_policy` * timescale#3106 Fix use after free in `chunk_api_get_chunk_stats` * timescale#3109 Copy recreated object permissions on update * timescale#3111 Fix `CMAKE_BUILD_TYPE` check * timescale#3112 Use `%u` to format Oid instead of `%d` * timescale#3118 Fix use after free in cache * timescale#3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` * timescale#3135 Fix SkipScan path generation in `DISTINCT` queries with expressions * timescale#3146 Fix SkipScan for IndexPaths without pathkeys * timescale#3147 Skip ChunkAppend if AppendPath has no children * timescale#3148 Make `SELECT DISTINCT` handle non-var targetlists * timescale#3151 Fix `fdw_relinfo_get` assertion failure on `DELETE` * timescale#3155 Inherit `CFLAGS` from PostgreSQL * timescale#3169 Fix incorrect type cast in compression policy * timescale#3183 Fix segfault in calculate_chunk_interval * timescale#3185 Fix wrong datatype in integer based retention policy **Thanks** * @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views * @hperez75 for reporting an issue with Skip Scan * @nathanloisel for reporting an issue with compression on hypertables with integer-based timestamps * @xin-hedera for fixing an issue with compression on hypertables with integer-based timestamps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This maintenance release contains bugfixes since the 2.2.0 release. We
deem it high priority for upgrading.
This release extends Skip Scan to multinode by enabling the pushdown
of
DISTINCTto data nodes. It also fixes a number of bugs in theimplementation of Skip Scan, in distributed hypertables, in creation
of indexes, in compression, and in policies.
Features
Scan
Bugfixes
get_git_commit()REINDEX TABLEfor distributed hypertablesadd_reorder_policychunk_api_get_chunk_statsCMAKE_BUILD_TYPEcheck%uto format Oid instead of%dREINDEX TABLE CONCURRENTLYDISTINCTquerieswith expressions
SELECT DISTINCThandle non-var targetlistsfdw_relinfo_getassertion failure onDELETECFLAGSfrom PostgreSQLThanks
multinode queries and views
with integer-based timestamps