Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass correct status to lock_job function #2543

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Pass correct status to lock_job function #2543

merged 1 commit into from
Oct 14, 2020

Conversation

gayyappan
Copy link
Contributor

@gayyappan gayyappan commented Oct 13, 2020 •
edited
Loading

lock_job is passed incorrect Status as argument.
The lock is incorrectly interpreted as a session
lock when a transaction lock is desired.

To reviewers: I ran into this due to a deadlock issue while executing bgw_db_scheduler.sql.

@codecov
Copy link

codecov bot commented Oct 13, 2020 •
edited
Loading

Codecov Report

Merging #2543 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2543      +/-   ##
==========================================
+ Coverage   90.06%   90.20%   +0.13%     
==========================================
  Files         212      212              
  Lines       34228    34178      -50     
==========================================
  Hits        30829    30829              
+ Misses       3399     3349      -50
Impacted Files Coverage Δ
src/bgw/job.c 95.07% <ø> (ø)
src/loader/bgw_message_queue.c 87.09% <0.00%> (ø)
src/import/planner.c 70.30% <0.00%> (+11.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79c064...a685eae. Read the comment docs.

@gayyappan gayyappan marked this pull request as ready for review October 13, 2020 15:50
@gayyappan gayyappan requested a review from a team as a code owner October 13, 2020 15:50
@gayyappan gayyappan requested review from pmwkaa, WireBaron and svenklemm and removed request for a team October 13, 2020 15:50
@gayyappan
Pass correct status to lock_job
a685eae 
lock_job is passed incorrect Status as argument.
The lock is incorrectly interpreted as a session
lock when a transaction lock is desired.
@gayyappan gayyappan merged commit cf34f7d into timescale:master Oct 14, 2020
svenklemm added a commit to svenklemm/timescaledb that referenced this pull request Oct 20, 2020
@svenklemm
Release 2.0.0-rc2
329b7fc 
This release candidate contains bugfixes since the previous release candidate.

**Minor Features**
* timescale#2520 Support non-transactional distibuted_exec

**Bugfixes**
* timescale#2307 Overflow handling for refresh policy with integer time
* timescale#2503 Remove error for correct bootstrap of data node
* timescale#2507 Fix validation logic when adding a new data node
* timescale#2510 Fix outer join qual propagation
* timescale#2514 Lock dimension slices when creating new chunk
* timescale#2515 Add if_attached argument to detach_data_node()
* timescale#2517 Fix member access within misaligned address in chunk_update_colstats
* timescale#2525 Fix index creation on hypertables with dropped columns
* timescale#2543 Pass correct status to lock_job
* timescale#2544 Assume custom time type range is same as bigint
* timescale#2563 Fix DecompressChunk path generation
* timescale#2564 Improve continuous aggregate datatype handling
* timescale#2568 Change use of ssl_dir GUC
* timescale#2571 Make errors and messages conform to style guide
@svenklemm svenklemm mentioned this pull request Oct 20, 2020
Merged
svenklemm added a commit to svenklemm/timescaledb that referenced this pull request Oct 20, 2020
@svenklemm
Release 2.0.0-rc2
e60cd7f 
This release candidate contains bugfixes since the previous release candidate.

**Minor Features**
* timescale#2520 Support non-transactional distibuted_exec

**Bugfixes**
* timescale#2307 Overflow handling for refresh policy with integer time
* timescale#2503 Remove error for correct bootstrap of data node
* timescale#2507 Fix validation logic when adding a new data node
* timescale#2510 Fix outer join qual propagation
* timescale#2514 Lock dimension slices when creating new chunk
* timescale#2515 Add if_attached argument to detach_data_node()
* timescale#2517 Fix member access within misaligned address in chunk_update_colstats
* timescale#2525 Fix index creation on hypertables with dropped columns
* timescale#2543 Pass correct status to lock_job
* timescale#2544 Assume custom time type range is same as bigint
* timescale#2563 Fix DecompressChunk path generation
* timescale#2564 Improve continuous aggregate datatype handling
* timescale#2568 Change use of ssl_dir GUC
* timescale#2571 Make errors and messages conform to style guide
* timescale#2577 Exclude compressed chunks from ANALYZE/VACUUM
svenklemm added a commit to svenklemm/timescaledb that referenced this pull request Oct 20, 2020
@svenklemm
Release 2.0.0-rc2
5b44608 
This release candidate contains bugfixes since the previous release candidate.

**Minor Features**
* timescale#2520 Support non-transactional distibuted_exec

**Bugfixes**
* timescale#2307 Overflow handling for refresh policy with integer time
* timescale#2503 Remove error for correct bootstrap of data node
* timescale#2507 Fix validation logic when adding a new data node
* timescale#2510 Fix outer join qual propagation
* timescale#2514 Lock dimension slices when creating new chunk
* timescale#2515 Add if_attached argument to detach_data_node()
* timescale#2517 Fix member access within misaligned address in chunk_update_colstats
* timescale#2525 Fix index creation on hypertables with dropped columns
* timescale#2543 Pass correct status to lock_job
* timescale#2544 Assume custom time type range is same as bigint
* timescale#2563 Fix DecompressChunk path generation
* timescale#2564 Improve continuous aggregate datatype handling
* timescale#2568 Change use of ssl_dir GUC
* timescale#2571 Make errors and messages conform to style guide
* timescale#2577 Exclude compressed chunks from ANALYZE/VACUUM
svenklemm added a commit that referenced this pull request Oct 20, 2020
@svenklemm
Release 2.0.0-rc2
709ed0d 
This release candidate contains bugfixes since the previous release candidate.

**Minor Features**
* #2520 Support non-transactional distibuted_exec

**Bugfixes**
* #2307 Overflow handling for refresh policy with integer time
* #2503 Remove error for correct bootstrap of data node
* #2507 Fix validation logic when adding a new data node
* #2510 Fix outer join qual propagation
* #2514 Lock dimension slices when creating new chunk
* #2515 Add if_attached argument to detach_data_node()
* #2517 Fix member access within misaligned address in chunk_update_colstats
* #2525 Fix index creation on hypertables with dropped columns
* #2543 Pass correct status to lock_job
* #2544 Assume custom time type range is same as bigint
* #2563 Fix DecompressChunk path generation
* #2564 Improve continuous aggregate datatype handling
* #2568 Change use of ssl_dir GUC
* #2571 Make errors and messages conform to style guide
* #2577 Exclude compressed chunks from ANALYZE/VACUUM
svenklemm added a commit that referenced this pull request Oct 20, 2020
@svenklemm
Release 2.0.0-rc2
413b2bf 
This release candidate contains bugfixes since the previous release candidate.

**Minor Features**
* #2520 Support non-transactional distibuted_exec

**Bugfixes**
* #2307 Overflow handling for refresh policy with integer time
* #2503 Remove error for correct bootstrap of data node
* #2507 Fix validation logic when adding a new data node
* #2510 Fix outer join qual propagation
* #2514 Lock dimension slices when creating new chunk
* #2515 Add if_attached argument to detach_data_node()
* #2517 Fix member access within misaligned address in chunk_update_colstats
* #2525 Fix index creation on hypertables with dropped columns
* #2543 Pass correct status to lock_job
* #2544 Assume custom time type range is same as bigint
* #2563 Fix DecompressChunk path generation
* #2564 Improve continuous aggregate datatype handling
* #2568 Change use of ssl_dir GUC
* #2571 Make errors and messages conform to style guide
* #2577 Exclude compressed chunks from ANALYZE/VACUUM
svenklemm added a commit that referenced this pull request Oct 20, 2020
@svenklemm
Release 2.0.0-rc2
468f34b 
This release candidate contains bugfixes since the previous release candidate.

**Minor Features**
* #2520 Support non-transactional distibuted_exec

**Bugfixes**
* #2307 Overflow handling for refresh policy with integer time
* #2503 Remove error for correct bootstrap of data node
* #2507 Fix validation logic when adding a new data node
* #2510 Fix outer join qual propagation
* #2514 Lock dimension slices when creating new chunk
* #2515 Add if_attached argument to detach_data_node()
* #2517 Fix member access within misaligned address in chunk_update_colstats
* #2525 Fix index creation on hypertables with dropped columns
* #2543 Pass correct status to lock_job
* #2544 Assume custom time type range is same as bigint
* #2563 Fix DecompressChunk path generation
* #2564 Improve continuous aggregate datatype handling
* #2568 Change use of ssl_dir GUC
* #2571 Make errors and messages conform to style guide
* #2577 Exclude compressed chunks from ANALYZE/VACUUM
@gayyappan gayyappan deleted the bgw_fix branch December 11, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmwkaa pmwkaa pmwkaa approved these changes

@WireBaron WireBaron WireBaron approved these changes

@svenklemm svenklemm svenklemm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gayyappan @pmwkaa @WireBaron @svenklemm