-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix outer join qual propagation #2510
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2510 +/- ##
==========================================
+ Coverage 90.01% 90.12% +0.11%
==========================================
Files 212 212
Lines 34223 34173 -50
==========================================
- Hits 30807 30800 -7
+ Misses 3416 3373 -43
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes regressions in some of the tests.
@@ -97,3 +97,93 @@ ORDER BY user_id, first_order_time, time1, min_time; | |||
|
|||
-- Cleanup | |||
DROP TABLE orders; | |||
---- OUTER JOIN tests --- | |||
--github issue 2500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might help to navigate to the issue in GH:
--github issue 2500 | |
--github issue #2500 |
time_bucket_annotate_walker passes an incorrect status for outer join to the function that checks quals eligibility for propagation. Fixes timescale#2500
This release candidate contains bugfixes since the previous release candidate. **Minor Features** * timescale#2520 Support non-transactional distibuted_exec **Bugfixes** * timescale#2307 Overflow handling for refresh policy with integer time * timescale#2503 Remove error for correct bootstrap of data node * timescale#2507 Fix validation logic when adding a new data node * timescale#2510 Fix outer join qual propagation * timescale#2514 Lock dimension slices when creating new chunk * timescale#2515 Add if_attached argument to detach_data_node() * timescale#2517 Fix member access within misaligned address in chunk_update_colstats * timescale#2525 Fix index creation on hypertables with dropped columns * timescale#2543 Pass correct status to lock_job * timescale#2544 Assume custom time type range is same as bigint * timescale#2563 Fix DecompressChunk path generation * timescale#2564 Improve continuous aggregate datatype handling * timescale#2568 Change use of ssl_dir GUC * timescale#2571 Make errors and messages conform to style guide
This release candidate contains bugfixes since the previous release candidate. **Minor Features** * timescale#2520 Support non-transactional distibuted_exec **Bugfixes** * timescale#2307 Overflow handling for refresh policy with integer time * timescale#2503 Remove error for correct bootstrap of data node * timescale#2507 Fix validation logic when adding a new data node * timescale#2510 Fix outer join qual propagation * timescale#2514 Lock dimension slices when creating new chunk * timescale#2515 Add if_attached argument to detach_data_node() * timescale#2517 Fix member access within misaligned address in chunk_update_colstats * timescale#2525 Fix index creation on hypertables with dropped columns * timescale#2543 Pass correct status to lock_job * timescale#2544 Assume custom time type range is same as bigint * timescale#2563 Fix DecompressChunk path generation * timescale#2564 Improve continuous aggregate datatype handling * timescale#2568 Change use of ssl_dir GUC * timescale#2571 Make errors and messages conform to style guide * timescale#2577 Exclude compressed chunks from ANALYZE/VACUUM
This release candidate contains bugfixes since the previous release candidate. **Minor Features** * timescale#2520 Support non-transactional distibuted_exec **Bugfixes** * timescale#2307 Overflow handling for refresh policy with integer time * timescale#2503 Remove error for correct bootstrap of data node * timescale#2507 Fix validation logic when adding a new data node * timescale#2510 Fix outer join qual propagation * timescale#2514 Lock dimension slices when creating new chunk * timescale#2515 Add if_attached argument to detach_data_node() * timescale#2517 Fix member access within misaligned address in chunk_update_colstats * timescale#2525 Fix index creation on hypertables with dropped columns * timescale#2543 Pass correct status to lock_job * timescale#2544 Assume custom time type range is same as bigint * timescale#2563 Fix DecompressChunk path generation * timescale#2564 Improve continuous aggregate datatype handling * timescale#2568 Change use of ssl_dir GUC * timescale#2571 Make errors and messages conform to style guide * timescale#2577 Exclude compressed chunks from ANALYZE/VACUUM
This release candidate contains bugfixes since the previous release candidate. **Minor Features** * #2520 Support non-transactional distibuted_exec **Bugfixes** * #2307 Overflow handling for refresh policy with integer time * #2503 Remove error for correct bootstrap of data node * #2507 Fix validation logic when adding a new data node * #2510 Fix outer join qual propagation * #2514 Lock dimension slices when creating new chunk * #2515 Add if_attached argument to detach_data_node() * #2517 Fix member access within misaligned address in chunk_update_colstats * #2525 Fix index creation on hypertables with dropped columns * #2543 Pass correct status to lock_job * #2544 Assume custom time type range is same as bigint * #2563 Fix DecompressChunk path generation * #2564 Improve continuous aggregate datatype handling * #2568 Change use of ssl_dir GUC * #2571 Make errors and messages conform to style guide * #2577 Exclude compressed chunks from ANALYZE/VACUUM
This release candidate contains bugfixes since the previous release candidate. **Minor Features** * #2520 Support non-transactional distibuted_exec **Bugfixes** * #2307 Overflow handling for refresh policy with integer time * #2503 Remove error for correct bootstrap of data node * #2507 Fix validation logic when adding a new data node * #2510 Fix outer join qual propagation * #2514 Lock dimension slices when creating new chunk * #2515 Add if_attached argument to detach_data_node() * #2517 Fix member access within misaligned address in chunk_update_colstats * #2525 Fix index creation on hypertables with dropped columns * #2543 Pass correct status to lock_job * #2544 Assume custom time type range is same as bigint * #2563 Fix DecompressChunk path generation * #2564 Improve continuous aggregate datatype handling * #2568 Change use of ssl_dir GUC * #2571 Make errors and messages conform to style guide * #2577 Exclude compressed chunks from ANALYZE/VACUUM
This release candidate contains bugfixes since the previous release candidate. **Minor Features** * #2520 Support non-transactional distibuted_exec **Bugfixes** * #2307 Overflow handling for refresh policy with integer time * #2503 Remove error for correct bootstrap of data node * #2507 Fix validation logic when adding a new data node * #2510 Fix outer join qual propagation * #2514 Lock dimension slices when creating new chunk * #2515 Add if_attached argument to detach_data_node() * #2517 Fix member access within misaligned address in chunk_update_colstats * #2525 Fix index creation on hypertables with dropped columns * #2543 Pass correct status to lock_job * #2544 Assume custom time type range is same as bigint * #2563 Fix DecompressChunk path generation * #2564 Improve continuous aggregate datatype handling * #2568 Change use of ssl_dir GUC * #2571 Make errors and messages conform to style guide * #2577 Exclude compressed chunks from ANALYZE/VACUUM
time_bucket_annotate_walker passes an incorrect status
for outer join to the function that checks quals eligibility
for propagation.
Fixes #2500