Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #542] update protobuf version to 3.16.1 (#539) #544

Merged

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Feb 28, 2022

cherry-pick #539 to release-3.2
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/544

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/544:release-3.2-36feccb3fa58

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

Issue Number: close #542

An issue in protobuf-java allowed the interleaving of com.google.protobuf.UnknownFieldSet fields in such a way that would be processed out of order. A small malicious payload can occupy the parser for several minutes by creating large numbers of short-lived objects that cause frequent, repeated pauses. We recommend upgrading libraries beyond the vulnerable versions.

https://nvd.nist.gov/vuln/detail/CVE-2021-22569

What is changed and how it works?

Fix: upgrade protobuf-java from 3.12.0 to 3.16.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome
Copy link
Collaborator

/merge

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@marsishandsome marsishandsome merged commit 80cf825 into tikv:release-3.2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants