[close #542] update protobuf version to 3.16.1 #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
============================================
- Coverage 32.01% 31.95% -0.06%
- Complexity 1310 1313 +3
============================================
Files 278 278
Lines 17344 17344
Branches 1975 1975
============================================
- Hits 5552 5542 -10
- Misses 11170 11181 +11
+ Partials 622 621 -1
Continue to review full report at Codecov.
|
|
what problem do you wish to solve by updating the protobuf version? |
|
marsishandsome
changed the title
|
@zz-jason @iosmanthus PTAL |
ti-srebot
approved these changes
Feb 28, 2022
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Feb 28, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.1 in PR #543 |
|
cherry pick to release-3.2 in PR #544 |
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Feb 28, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
marsishandsome
added a commit
that referenced
this pull request
Mar 1, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
marsishandsome
added a commit
that referenced
this pull request
Mar 1, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
shiyuhang0
pushed a commit
to shiyuhang0/client-java
that referenced
this pull request
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: marsishandsome marsishandsome@gmail.com
What problem does this PR solve?
Issue Number: close #542
An issue in protobuf-java allowed the interleaving of com.google.protobuf.UnknownFieldSet fields in such a way that would be processed out of order. A small malicious payload can occupy the parser for several minutes by creating large numbers of short-lived objects that cause frequent, repeated pauses. We recommend upgrading libraries beyond the vulnerable versions.
https://nvd.nist.gov/vuln/detail/CVE-2021-22569
What is changed and how it works?
Fix: upgrade protobuf-java from
3.12.0to3.16.1