-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CDCClient to client-java with a few tiny changes for TiFlink #174
Conversation
build failed
|
@marsishandsome What's the desire JDK version for java-client now? It's a java11 method. |
java8 |
@marsishandsome Updated to java8 |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@birdstorm PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One more question, @shanzi can you please describe how to use multiple CDCClient at the same time? e.g., are there any precautions, and what would happen if the key ranges collide? |
@birdstorm one CDCClient can only accept one key range, when using multiple CDCClients at the same time, each one will just work independently. The user is responsible for assigning proper key ranges for each. Thus overlapping key range won't have any problem. In other words, if the user runs two clients with overlapping key range, there will be two RegionCDCClient to the same region/store (That's why we don't use any Channel cache). @marsishandsome Can I merge this now? And what's the schedule to release 3.1.0? Thanks. |
Will two RegionCDCClient to the same region/store be a problem? That is what I am concerned about. |
@birdstorm There will be two channels to the single store. So, I think there won't be any issue. |
Signed-off-by: chase <yun.er.run@gmail.com>
Signed-off-by: chase <yun.er.run@gmail.com>
Signed-off-by: chase <yun.er.run@gmail.com>
Signed-off-by: chase <yun.er.run@gmail.com>
Signed-off-by: chase <yun.er.run@gmail.com>
This PR adds the pure java implementation of CDCClient which comunicates directly with TiKV with GRPC for change logs. It also includes some tiny changes to make TiFlink's implementation easier.
For details about TiFlink, please see this link.