Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TiDB-CDC] Support TiDB CDC connector #243

Closed
peigenxiao opened this issue Jul 12, 2021 · 7 comments
Closed

[TiDB-CDC] Support TiDB CDC connector #243

peigenxiao opened this issue Jul 12, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@peigenxiao
Copy link

mysql> select version();
+--------------------+
| version() |
+--------------------+
| 5.7.25-TiDB-v5.1.0 |
+--------------------+

like:
CREATE TEST_CDC (
ID STRING,
OPTY_ID STRING,
ACCEPT_DATE STRING,
ORG_ID STRING,
BRAND_LABEL STRING,
CURRENT_STATUS STRING,
PAID_AMOUNT STRING,
DEALER_ID STRING,
RECORD_STATUS STRING
)WITH (
'connector' = 'mysql-cdc',
'hostname' = 'xxxx',
'port' = '4000',
'username' = 'root',
'password' = 'xxxx',
'database-name' = 'flink',
'table-name' = 'test_cdc'
);

@Al-assad
Copy link
Member

Al-assad commented Jul 12, 2021

@peigenxiao
The CDC implementation mechanism is different for MySQL and TiDB. We have provided flink-cdc-tidb-connector support for TiDB in tidb-incubator/Tibigdata project which has not yet been officially released. It was actually implemented by way of HybridSource introduced in Flink-1.13.
follow in https://github.com/tidb-incubator/TiBigData/tree/master/flink

@zoucao
Copy link

zoucao commented Jul 13, 2021

hi @Al-assad, I take a cursory look at Tibigdata, it is a good project, combine batch and streaming, I found it use ticdc to collect the incremental data, right? Why don't use tikv-java-client and StreamObserver, such that we can get record from grpc directly just like the ticdc. What are your concerns or are there any disadvantages you don’t choose it ?

@Al-assad
Copy link
Member

Al-assad commented Jul 13, 2021

@zoucao The cdc-client of tikv-java-client was designed by @shanzi, used in TiFlink project and only recently merged into tikv-java-client project (tikv/client-java#174). Actually the unified streaming source design of TiBigData has been planned by @sunxiaoguang at an earlier time.
Both designs have their own advantages and disadvantages, you can access the discussion at here. welcome to discuss in more details in TiBigData community 👋🏻.

@zoucao
Copy link

zoucao commented Jul 13, 2021

Thanks for your replying, @Al-assad , serveral months ago, I made some changes based on tiflink and wanted it could be used in our internal, but I found it was not perfect and had many problems need to fix. From your perspective,which project will the community put more effort into ?

@Al-assad
Copy link
Member

Thanks for your replying, @Al-assad , serveral months ago, I made some changes based on tiflink and wanted it could be used in our internal, but I found it was not perfect and had many problems need to fix. From your perspective,which project will the community put more effort into ?

personally speaking, both may co-exist to meet various scenarios. tikv-java makes application more streamlined while ticdc has greater isolation

@leonardBang leonardBang added the enhancement New feature or request label Aug 20, 2021
@leonardBang leonardBang changed the title is whether you will support Tidb? [TiDB-CDC] Support TiDB CDC connector Mar 1, 2022
@teckick
Copy link
Contributor

teckick commented Mar 1, 2022

@leonardBang Please assign to me

@leonardBang
Copy link
Contributor

Thanks for picking up this ticket @eastfisher, assigned to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants