Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Fix aip_xx1's pointcloud_preprocessor.launch.py #72

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

kenji-miyake
Copy link
Contributor

Replace hardcoded 'base_link' with LaunchConfiguration.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake requested a review from wep21 March 1, 2021 10:18
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

❯ ros2 launch pointcloud_preprocessor.launch.py vehicle_param_file:=/home/daisuke/workspace/AutowareArchitectureProposal/src/description/vehicle/lexus_description/config/vehicle_info.param.yaml use_concat_filter:=true base_frame:=test
❯ ros2 param dump /concatenate_data --print
1614644755.090918 [36]       ros2: using network interface wlp2s0 (udp/192.168.150.52) selected arbitrarily from: wlp2s0, virbr0, docker0
concatenate_data:
  ros__parameters:
    input_topics:
    - /sensing/lidar/top/outlier_filtered/pointcloud
    - /sensing/lidar/left/outlier_filtered/pointcloud
    - /sensing/lidar/right/outlier_filtered/pointcloud
    max_queue_size: 3
    output_frame: test
    timeout_sec: 0.1
    use_sim_time: false

@wep21 wep21 merged commit 3331f97 into ros2-v0.9.0-beta Mar 2, 2021
@wep21 wep21 deleted the fix-aip-xx1-launch branch March 2, 2021 00:28
mitsudome-r pushed a commit to mitsudome-r/autoware_launcher.iv.universe that referenced this pull request Mar 2, 2021
* tmp rename launch file

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Add system_monitor to system.launch (tier4#72)

* Add system_monitor to system.launch

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add config file of system_monitor (tier4#115)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add config of diagnostic_aggregator (tier4#128)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add vehicle cmd gate config (tier4#136)

* Add config_file of vehicle_cmd_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_emergency_stop

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename emergency_stop to external_emergency_stop

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix command_gate diag

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_emergency_hold arg (tier4#142)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix system.launch (tier4#161)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Revert "tmp rename launch file"

This reverts commit d1bb989.

* fix launch file

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* fix minor bug

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* rename .yaml -> .param.yaml

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* fix invalid way to use eval

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Add new line in yaml

* add num_disks

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* rename .yaml to .param.yaml

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
tier4-autoware-private-bot bot pushed a commit that referenced this pull request Sep 14, 2021
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
kosuke55 pushed a commit that referenced this pull request Jan 17, 2023
* feat(autoware_launch): apply the change of pose initializer

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix: add group for include scope

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants