Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat(planning_validator): add planning_validator pkg #675

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jan 2, 2023

Signed-off-by: Takamasa Horibe horibe.takamasa@gmail.com

PR Type

  • New Feature

Related Links

(for TIER IV internal tracker: https://tier4.atlassian.net/browse/T4PB-18620)

Description

Change for autowarefoundation/autoware.universe#1947

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

tkimura4
tkimura4 previously approved these changes Jan 16, 2023
tkimura4
tkimura4 previously approved these changes Jan 18, 2023
Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(Could you add depenency to package.xml?)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants