[ROS2 Porting] perception_launch #6
Conversation
esteve
force-pushed
the
port-perception-launch
branch
from
40eb5a6
to
8884d46
Compare
esteve
force-pushed
the
port-perception-launch
branch
from
a03e780
to
efab819
Compare
There was a problem hiding this comment.
I noticed quite a few number of changes required to run the launch file.
I have created PR to your branch with the fixes I had to make. esteve#1.
Please consider merging it to your branch.
.github/workflows/build_and_test.yml
Outdated
| @@ -31,7 +31,7 @@ jobs: | |||
| - name: Build | |||
| run: | | |||
| . /opt/ros/foxy/setup.sh | |||
| colcon build --event-handlers console_cohesion+ | |||
| colcon build --event-handlers console_cohesion+ --packages-up-to control_launch integration_launch localization_launch map_launch perception_launch planning_launch sensing_launch system_launch vehicle_launch | |||
There was a problem hiding this comment.
Maybe we don't need this until all packages are ported?
There was a problem hiding this comment.
The problem is that if we don't filter the packages, the whole workspace will be built, including all the dependencies.
There was a problem hiding this comment.
But that would mean CI will always fail because it fails to find packages that are not ported.
I would suggest either update CI as we do the port, or always build whole workspace.
There was a problem hiding this comment.
Yes, that once a package is ported, move it from --packages-ignore to --packages-up-to. Building the entire workspace takes a lot of time now that Pilot.Auto has been added to the build_depends.repos file in this repository.
esteve
force-pushed
the
port-perception-launch
branch
from
5aa4e39
to
23bb544
Compare
|
I've rebased this on top of #16 to pick up the new dependencies. |
esteve
force-pushed
the
port-perception-launch
branch
2 times, most recently
from
bcc2dbb
to
a26ba2f
Compare
| <arg name="image_raw7" default="$(arg image_raw7)"/> | ||
| <arg name="image_number" default="$(arg image_number)"/> | ||
| <!-- <include file="$(find-pkg-share tensorrt_yolo3)/launch/yolo3.launch.xml"> | ||
| <let var="image_raw0" value="$(var image_raw0)"/> |
There was a problem hiding this comment.
Sorry, I think I was the one to change arg to let, but I later found out that setting variables using let wouldn't pass them to included file.
Could you switch it back to arg?
You have to use arg with value as shown in the suggestion. (This sounds weird since the migration guide states that value for arg is not supported anymore, but that was the only way to pass arguments to the included launch file)
| <let var="image_raw0" value="$(var image_raw0)"/> | |
| <arg var="image_raw0" value="$(var image_raw0)"/> |
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
esteve
force-pushed
the
port-perception-launch
branch
from
a26ba2f
to
7ae696e
Compare
* autoware_iv_auto_msgs_converter -> tier4_auto_msgs_converter * autoware_external_api_msgs -> tier4_external_api_msgs * autoware_api_utils -> tier4_api_utils * autoware_vehicle_msgs -> tier4_vehicle_msgs * fix format
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
sync upstream
* fix(planning_launch): enable blind spot launch and change its params * fix(planning_launch): change stop_margin param * fix(planning_launch): revert stop_margin param * fix(planning_launch): change ego_pass_first_margin param
No description provided.