Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Ros2 v0.8.0 perception launch #56

Merged
merged 15 commits into from
Feb 19, 2021
Merged

Conversation

TakaHoribe
Copy link
Contributor

No description provided.

@TakaHoribe TakaHoribe added the ros2-v0.8.0 update ros2 branch to v0.8.0 label Feb 15, 2021
@wep21 wep21 force-pushed the ros2-v0.8.0-perception-launch branch from d0163ae to a63d909 Compare February 16, 2021 08:50
@mitsudome-r
Copy link
Collaborator

Fixed in adc7824

@@ -4,17 +4,17 @@
<!-- common parameters -->
<arg name="mode" default="camera_lidar_fusion"/>
<!-- "camera_lidar_fusion", "lidar" or "camera" -->
<arg name="image_raw0" default="/sensing/camera/0/image_raw"/>
<arg name="image_raw0" default="/sensing/camera/0/image_rect_color"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single number in namaspace or name is not allowed in ros2.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.
This is fixed in 2bc1a5e

@@ -18,6 +18,8 @@
<exec_depend>naive_path_prediction</exec_depend>
<exec_depend>roi_cluster_fusion</exec_depend>
<exec_depend>shape_estimation</exec_depend>
<exec_depend>tensorrt_yolo</exec_depend>
<exec_depend>object_range_splitter</exec_depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing object_merger

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in cd9edd0

TakaHoribe and others added 10 commits February 18, 2021 14:11
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
* cosmetic change

* add image topic

* fix bug
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
wep21 added 3 commits February 18, 2021 17:50
…ition

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 force-pushed the ros2-v0.8.0-perception-launch branch from df6d5f5 to 3112700 Compare February 18, 2021 08:50
wep21 added 2 commits February 19, 2021 14:17
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 self-requested a review February 19, 2021 06:42
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wep21 wep21 merged commit 5347ed7 into ros2-v0.8.0-beta Feb 19, 2021
@wep21 wep21 deleted the ros2-v0.8.0-perception-launch branch February 19, 2021 06:43
kosuke55 pushed a commit that referenced this pull request Jul 8, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
tzhong518 pushed a commit that referenced this pull request Aug 1, 2022
takayuki5168 pushed a commit that referenced this pull request Jan 21, 2023
* temporary commit tlr_nodelet

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* compressed to compressed

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Update traffic_light.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* change image_transport to relay

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* decompress as rgb8

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ros2-v0.8.0 update ros2 branch to v0.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants