Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Ros2 v0.8.0 sensing launch #48

Closed

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Feb 8, 2021

TODO

  • How the min_x = /vehicle_info/length in the launch.py should be handled? -> pass vehicle_param_file and parse it in the launch file.

NOTE:

When launch/api_**/pointcloud_preprocessor.launch.py is launched, the user interruption with ctrl-c fails to kill nodes.

TakaHoribe and others added 18 commits February 8, 2021 17:36
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
* fix pass through filter launch

* change if statement style
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
* support individual params

* remove kvaser_hardware_id.txt
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
…ssor

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
This reverts commit 37d7ac4.
@TakaHoribe TakaHoribe added the ros2-v0.8.0 update ros2 branch to v0.8.0 label Feb 8, 2021
@TakaHoribe TakaHoribe changed the title Ros2 v0.8.0 sensing launch [WIP] Ros2 v0.8.0 sensing launch Feb 8, 2021
…r launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…processor.launch.py

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested a review from wep21 February 9, 2021 06:48
@TakaHoribe TakaHoribe changed the title [WIP] Ros2 v0.8.0 sensing launch Ros2 v0.8.0 sensing launch Feb 9, 2021
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@wep21
Copy link
Contributor

wep21 commented Feb 15, 2021

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe
Copy link
Contributor Author

Fix livox launch

@TakaHoribe TakaHoribe closed this Feb 15, 2021
kosuke55 pushed a commit that referenced this pull request Jul 8, 2022
Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ros2-v0.8.0 update ros2 branch to v0.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants