Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

fix/add pointcloud_preprocessor depend #146

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Dec 2, 2021

PR Type

  • Bug Fix ?
  • There is a possibility that the pointcloud_preprocessor component will not load properly without this depend...

Related Links

Description

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@satoshi-ota satoshi-ota marked this pull request as ready for review December 2, 2021 12:59
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some plugins in pointcloud_preprocessor are loaded successfully, so I wonder if this is a cause of the error, but it looks good to me for dependency fix.

❯ ag pointcloud_preprocessor:: ~/Downloads/001-LSim-1-001-Universe_case_bd63f134-6090-4171-881e-773b6beb79a0.log
125:[component_container-23] [INFO] [1638412502.496630982] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::ApproximateDownsampleFilterComponent>
126:[component_container-23] [INFO] [1638412502.496685944] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::CropBoxFilterComponent>
127:[component_container-23] [INFO] [1638412502.496707614] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::CropBoxFilterComponent>
132:[component_container-24] [INFO] [1638412501.544480688] [sensing.lidar.front_right.livox_horizon.livox_horizon]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::ApproximateDownsampleFilterComponent>
133:[component_container-24] [INFO] [1638412501.544543868] [sensing.lidar.front_right.livox_horizon.livox_horizon]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::CropBoxFilterComponent>
134:[component_container-24] [INFO] [1638412501.544599688] [sensing.lidar.front_right.livox_horizon.livox_horizon]: Instantiate class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::CropBoxFilterComponent>
144:[component_container-25] [INFO] [1638412501.496853700] [sensing.lidar.front_center.livox_horizon.livox_horizon]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::ApproximateDownsampleFilterComponent>
145:[component_container-25] [INFO] [1638412501.496907000] [sensing.lidar.front_center.livox_horizon.livox_horizon]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::CropBoxFilterComponent>
146:[component_container-25] [INFO] [1638412501.496924290] [sensing.lidar.front_center.livox_horizon.livox_horizon]: Instantiate class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::CropBoxFilterComponent>
156:[component_container-26] [INFO] [1638412501.865847558] [sensing.lidar.front_left.livox_horizon.livox_horizon]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::ApproximateDownsampleFilterComponent>
157:[component_container-26] [INFO] [1638412501.865909499] [sensing.lidar.front_left.livox_horizon.livox_horizon]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::CropBoxFilterComponent>
158:[component_container-26] [INFO] [1638412501.865930959] [sensing.lidar.front_left.livox_horizon.livox_horizon]: Instantiate class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::CropBoxFilterComponent>
165:[component_container-27] [INFO] [1638412501.577539807] [sensing.lidar.pointcloud_preprocessor.pointcloud_preprocessor_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::ApproximateDownsampleFilterComponent>
166:[component_container-27] [INFO] [1638412501.577597107] [sensing.lidar.pointcloud_preprocessor.pointcloud_preprocessor_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::CropBoxFilterComponent>
167:[component_container-27] [INFO] [1638412501.577614928] [sensing.lidar.pointcloud_preprocessor.pointcloud_preprocessor_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::DistortionCorrectorComponent>
168:[component_container-27] [INFO] [1638412501.577629708] [sensing.lidar.pointcloud_preprocessor.pointcloud_preprocessor_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::DualReturnOutlierFilterComponent>
169:[component_container-27] [INFO] [1638412501.577644398] [sensing.lidar.pointcloud_preprocessor.pointcloud_preprocessor_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::Lanelet2MapFilterComponent>
170:[component_container-27] [INFO] [1638412501.577658379] [sensing.lidar.pointcloud_preprocessor.pointcloud_preprocessor_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::OccupancyGridMapOutlierFilterComponent>
171:[component_container-27] [INFO] [1638412501.577672079] [sensing.lidar.pointcloud_preprocessor.pointcloud_preprocessor_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::PassThroughFilterComponent>
172:[component_container-27] [INFO] [1638412501.577686189] [sensing.lidar.pointcloud_preprocessor.pointcloud_preprocessor_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::PassThroughFilterUInt16Component>
173:[component_container-27] [INFO] [1638412501.577699739] [sensing.lidar.pointcloud_preprocessor.pointcloud_preprocessor_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::PointCloudConcatenateDataSynchronizerComponent>
174:[component_container-27] [INFO] [1638412501.577713699] [sensing.lidar.pointcloud_preprocessor.pointcloud_preprocessor_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::PointCloudConcatenateDataSynchronizerComponent>
345:[component_container_mt-30] [ERROR] [1638412505.021228043] [perception.obstacle_segmentation.ground_segmentation.perception_pipeline_container]: Failed to find class with the requested plugin name 'pointcloud_preprocessor::PointCloudConcatenateDataSynchronizerComponent' in the loaded library
346:[component_container_mt-30] [ERROR] [1638412505.025242346] [perception.obstacle_segmentation.ground_segmentation.perception_pipeline_container]: Failed to find class with the requested plugin name 'pointcloud_preprocessor::PointCloudConcatenateDataSynchronizerComponent' in the loaded library
347:[ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'concatenate_data' of type 'pointcloud_preprocessor::PointCloudConcatenateDataSynchronizerComponent' in container '/perception/obstacle_segmentation/ground_segmentation/perception_pipeline_container': Failed to find class with the requested plugin name.
348:[component_container_mt-30] [ERROR] [1638412505.029609302] [perception.obstacle_segmentation.ground_segmentation.perception_pipeline_container]: Failed to find class with the requested plugin name 'pointcloud_preprocessor::CropBoxFilterComponent' in the loaded library
350:[ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'livox_concatenate_data' of type 'pointcloud_preprocessor::PointCloudConcatenateDataSynchronizerComponent' in container '/perception/obstacle_segmentation/ground_segmentation/perception_pipeline_container': Failed to find class with the requested plugin name.
351:[ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'crop_box_filter' of type 'pointcloud_preprocessor::CropBoxFilterComponent' in container '/perception/obstacle_segmentation/ground_segmentation/perception_pipeline_container': Failed to find class with the requested plugin name.
354:[component_container_mt-30] [ERROR] [1638412505.108662523] [perception.obstacle_segmentation.ground_segmentation.perception_pipeline_container]: Failed to find class with the requested plugin name 'pointcloud_preprocessor::VoxelGridDownsampleFilterComponent' in the loaded library
355:[component_container_mt-30] [ERROR] [1638412505.117905549] [perception.obstacle_segmentation.ground_segmentation.perception_pipeline_container]: Failed to find class with the requested plugin name 'pointcloud_preprocessor::CropBoxFilterComponent' in the loaded library
361:[ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'voxel_grid_filter' of type 'pointcloud_preprocessor::VoxelGridDownsampleFilterComponent' in container '/perception/obstacle_segmentation/ground_segmentation/perception_pipeline_container': Failed to find class with the requested plugin name.
362:[ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'short_height_obstacle_detection_area_filter' of type 'pointcloud_preprocessor::CropBoxFilterComponent' in container '/perception/obstacle_segmentation/ground_segmentation/perception_pipeline_container': Failed to find class with the requested plugin name.
396:[component_container-23] [INFO] [1638412505.762370336] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::ApproximateDownsampleFilterComponent>
397:[component_container-23] [INFO] [1638412505.762494736] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::CropBoxFilterComponent>
398:[component_container-23] [INFO] [1638412505.762518366] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::DistortionCorrectorComponent>
399:[component_container-23] [INFO] [1638412505.762533917] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::DualReturnOutlierFilterComponent>
400:[component_container-23] [INFO] [1638412505.762548787] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::Lanelet2MapFilterComponent>
401:[component_container-23] [INFO] [1638412505.762563567] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::OccupancyGridMapOutlierFilterComponent>
402:[component_container-23] [INFO] [1638412505.762632628] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::PassThroughFilterComponent>
403:[component_container-23] [INFO] [1638412505.762649168] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::PassThroughFilterUInt16Component>
404:[component_container-23] [INFO] [1638412505.762663128] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::PointCloudConcatenateDataSynchronizerComponent>
405:[component_container-23] [INFO] [1638412505.762677138] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::PointcloudAccumulatorComponent>
406:[component_container-23] [INFO] [1638412505.762752599] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::RadiusSearch2DOutlierFilterComponent>
407:[component_container-23] [INFO] [1638412505.762773109] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::RandomDownsampleFilterComponent>
408:[component_container-23] [INFO] [1638412505.762786939] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Found class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::RingOutlierFilterComponent>
409:[component_container-23] [INFO] [1638412505.762800469] [sensing.lidar.top.pointcloud_preprocessor.velodyne_node_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<pointcloud_preprocessor::RingOutlierFilterComponent>
489:[component_container_mt-30] [ERROR] [1638412507.318887743] [perception.obstacle_segmentation.ground_segmentation.perception_pipeline_container]: Failed to find class with the requested plugin name 'pointcloud_preprocessor::VoxelGridOutlierFilterComponent' in the loaded library
490:[ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'voxel_grid_outlier_filter' of type 'pointcloud_preprocessor::VoxelGridOutlierFilterComponent' in container '/perception/obstacle_segmentation/ground_segmentation/perception_pipeline_container': Failed to find class with the requested plugin name.
491:[component_container_mt-30] [ERROR] [1638412507.346207449] [perception.obstacle_segmentation.ground_segmentation.perception_pipeline_container]: Failed to find class with the requested plugin name 'pointcloud_preprocessor::Lanelet2MapFilterComponent' in the loaded library
492:[ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'vector_map_filter' of type 'pointcloud_preprocessor::Lanelet2MapFilterComponent' in container '/perception/obstacle_segmentation/ground_segmentation/perception_pipeline_container': Failed to find class with the requested plugin name.

@satoshi-ota satoshi-ota merged commit 0da4ddf into use-autoware-auto-msgs Dec 2, 2021
@satoshi-ota satoshi-ota deleted the fix/add-depend-pointcloud-preprocessor branch December 2, 2021 13:29
kazuki527 pushed a commit to kazuki527/autoware_launch that referenced this pull request Apr 25, 2022
takayuki5168 pushed a commit that referenced this pull request May 26, 2022
…_to_system_launch

bagkeeperをマージしたので本PRもマージ。
tzhong518 pushed a commit that referenced this pull request Aug 1, 2022
kosuke55 pushed a commit that referenced this pull request Jan 17, 2023
…#146)

* feat(avoidance): add new param for yield maneuver in avoidance module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): fix param name for readability

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(planning_launch): add missing param

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants