This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
ROS2 Linting: control_launch #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteve
approved these changes
Dec 18, 2020
|
@jilaada @mitsudome-r should we wait to merge this PR until |
We could wait until it gets merged. It might be better than creating yet another PR to uncomment one line haha |
|
Looks like the |
tier4-autoware-public-bot bot
pushed a commit
that referenced
this pull request
Apr 12, 2022
updates: - [github.com/pre-commit/pre-commit-hooks: v4.1.0 → v4.2.0](pre-commit/pre-commit-hooks@v4.1.0...v4.2.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kazuki527
pushed a commit
to kazuki527/autoware_launch
that referenced
this pull request
Apr 25, 2022
sync upstream
This was referenced Jan 21, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added linters to the control launch
ament_lint_common. Not sure if this is necessary but I also add the package dependencies that were missing before. I know that the descriptions packages did not require linters but I wasn't sure about these launch packages if they benefit from addingament_lint_common.Note: It seems like
pure_pursuitis not ported yet but is a dependency in this package.