Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up acceptance test with shared examples #827

Merged
merged 3 commits into from
Apr 20, 2020

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Apr 17, 2020

This is taking a part of #699 but leaves out the beaker-hiera changes and shared context to get it in a mergeable state.

Since 8bc1ba3 he default deployment is
now a reverse proxy so this test is redundant.
All testing is now happening on a reverse proxy so these are no longer
needed.
@ekohl ekohl force-pushed the introduce-acceptance-shared-examples branch from 02767a4 to bc68a37 Compare April 20, 2020 16:07
@ekohl
Copy link
Member Author

ekohl commented Apr 20, 2020

Updated, copied the shared example from a branch that also included another change already (moving the certs to /etc/foreman-certs). Should pass now.

@ekohl ekohl force-pushed the introduce-acceptance-shared-examples branch from bc68a37 to d1ec102 Compare April 20, 2020 16:25
@mmoll mmoll merged commit cd3b1c9 into theforeman:master Apr 20, 2020
@mmoll
Copy link
Contributor

mmoll commented Apr 20, 2020

merged, bedankt @ekohl!

@ekohl ekohl deleted the introduce-acceptance-shared-examples branch May 1, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants