Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modulesync: use voxpupuli helper gems #823

Merged
merged 7 commits into from
Apr 22, 2020

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Apr 11, 2020

No description provided.

@ekohl
Copy link
Member Author

ekohl commented Apr 16, 2020

Needs #825 & #824. Will rebase once merged and see if it's green then.

@ekohl ekohl marked this pull request as ready for review April 16, 2020 21:58
@ekohl
Copy link
Member Author

ekohl commented Apr 16, 2020

Rebased and updated. Let's see if this is green.

@ekohl ekohl marked this pull request as draft April 16, 2020 22:21
@ekohl ekohl force-pushed the voxpupuli-helpers branch 2 times, most recently from 95975f5 to a93988c Compare April 17, 2020 16:49
@ekohl
Copy link
Member Author

ekohl commented Apr 17, 2020

#827 & #826 should go in first.

@mmoll
Copy link
Contributor

mmoll commented Apr 20, 2020

@ekohl please rebase :)

@ekohl ekohl force-pushed the voxpupuli-helpers branch 2 times, most recently from dfe4260 to 1b04be0 Compare April 21, 2020 10:10
@ekohl ekohl marked this pull request as ready for review April 21, 2020 10:35
@ekohl ekohl force-pushed the voxpupuli-helpers branch 3 times, most recently from 64f84f5 to a835607 Compare April 21, 2020 14:58
spec/support/override_facts.rb Outdated Show resolved Hide resolved
@ekohl ekohl marked this pull request as draft April 21, 2020 18:17
Note that it disables EPEL which we no longer need.
This avoids generating certificates for every example and makes the
examples easier.
@ekohl ekohl marked this pull request as ready for review April 21, 2020 22:00
@ekohl
Copy link
Member Author

ekohl commented Apr 21, 2020

If this is green, it should finally be ready to merge. It does include some changes that are technically not entirely needed and could be merged separate, but it was easier to develop this way. They are separated as commits which hopefully keeps the review easier.

@mmoll
Copy link
Contributor

mmoll commented Apr 22, 2020

This is pretty great 😍

@mmoll mmoll merged commit 6b7d827 into theforeman:master Apr 22, 2020
@mmoll
Copy link
Contributor

mmoll commented Apr 22, 2020

merged, bedankt @ekohl!

@ekohl ekohl deleted the voxpupuli-helpers branch April 22, 2020 07:31
@wbclark wbclark linked an issue May 12, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use modern facts
4 participants