Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests for #974 and #975 #977

Closed
wants to merge 2 commits into from
Closed

Failing tests for #974 and #975 #977

wants to merge 2 commits into from

Conversation

timhall
Copy link
Contributor

@timhall timhall commented Dec 4, 2017

In case this is helpful, wanted to add failing tests for #974 and #975

@Rich-Harris Rich-Harris mentioned this pull request Dec 5, 2017
@Rich-Harris
Copy link
Member

Thank you, they are very helpful! Fixed in #980 so I'll close this.

One thing I didn't fix, which your test revealed, is this:

{{#if foo}}
  {{#await alreadyFulfilled}}
    <p>this will be rendered initially when foo becomes true</p>
  {{then}}
    <p>then this will immediately replace it</p>
  {{catch}}
    <!-- ... -->
  {{/await}}
{{/if}}

Will open a separate issue for that.

@Rich-Harris Rich-Harris closed this Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants