Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

await throws error with null anchor #974

Closed
timhall opened this issue Dec 4, 2017 · 1 comment
Closed

await throws error with null anchor #974

timhall opened this issue Dec 4, 2017 · 1 comment

Comments

@timhall
Copy link
Contributor

timhall commented Dec 4, 2017

Love the await block, but ran into an issue with cases where an anchor isn't needed (which I think could be relatively often).

Example: https://svelte.technology/repl?version=1.44.1&gist=2280c071cccd0dbc9cf0b873540c2c4f

I think the following line needs a guard for null anchor value (needsAnchor = false), but I'm not sure what it should look like:

${await_block}.m(${anchor}.parentNode, ${anchor});
.

@Rich-Harris
Copy link
Member

This and #975 are fixed in 1.44.2. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants