Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent erroneous missing data warnings for custom elements #1154

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

Rich-Harris
Copy link
Member

fixes #1065

@codecov-io
Copy link

codecov-io commented Feb 4, 2018

Codecov Report

Merging #1154 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
+ Coverage   91.48%   91.49%   +<.01%     
==========================================
  Files         126      126              
  Lines        4524     4526       +2     
  Branches     1461     1462       +1     
==========================================
+ Hits         4139     4141       +2     
  Misses        163      163              
  Partials      222      222
Impacted Files Coverage Δ
src/generators/dom/index.ts 95.53% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a1569...9dda4b0. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 25b1f05 into master Feb 9, 2018
@Rich-Harris Rich-Harris deleted the gh-1065 branch February 9, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom elements always get missing data warnings in dev mode
3 participants