Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom elements always get missing data warnings in dev mode #1065

Closed
Rich-Harris opened this issue Jan 2, 2018 · 0 comments · Fixed by #1154
Closed

Custom elements always get missing data warnings in dev mode #1065

Rich-Harris opened this issue Jan 2, 2018 · 0 comments · Fixed by #1154
Labels

Comments

@Rich-Harris
Copy link
Member

Because of the way custom elements work, if you have the traditional hello world component...

<h1>Hello {{name}}!</h1>

<script>
  export default {
    tag: 'my-app'
  };
</script>

...and create it like so...

document.body.innerHTML = `<my-app name='world'/>`;

...then at the time of creation, the name property is unpopulated (the callback fires immediately after construction).

In dev mode, this means you get incorrect warnings about missing properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant