Uniqueness check on pool whitelisting #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add uniqueness check via pool id
add pool id to fetch from deployer
add pool id to fetch from deployer
add pool id to fetch from deployer
add pool id to fetch from deployer
nit comments
nit comments
nit comments
Pull Request Test Coverage Report for Build 1361983274
💛 - Coveralls |
chxash
reviewed
Oct 21, 2021
| whitelistedFactories[_factory] = true; | ||
| bytes32 identifier = IPool(_factory).poolIdentifier(); | ||
| for (uint256 i = 0; i < factoryList.length; i++) { | ||
| require(identifier != factories[factoryList[i]].identifier, "FACTORY_NOT_UNIQUE"); |
There was a problem hiding this comment.
is it possible to unit test this behaviour ?
chxash
reviewed
Oct 21, 2021
| mapping(address => bool) public whitelistedFactories; | ||
| mapping(address => Type) public factories; | ||
|
|
||
| struct Type { |
There was a problem hiding this comment.
Maybe we can find a more meaningful name, FactoryInfo ? or something else
chxash
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds check in
addToWhitelistthat reads from stored pool identifier to confirm duplicative pools are not added toMasterDeployerwhitelist.seeks to resolve #253