Identifier uniqueness isn't enforced

[matthewlilley]

Pool implementations require a poolIdentifier to satisfiy IPool.

/// @return A unique identifier for the pool type.
function poolIdentifier() external pure returns (bytes32);

However, uniqueness is not enforced, it probably makes sense to do this.

I did suggest an alternative too which might be worth thinking about, and could be quite useful for consumers, a pool indentifier + version e.g ID: ConstantProductPool, VERSION: 1 etc..., uniqueness of the combination would need to be enforced.

[z0r0z]

uniqueness shouldn't be hard to enforce by adding a check in MasterDeployer and the addToWhitelist function (& storing the identifier for each pool (factory)). So, no extra costs to Trident users. Though, arguably, we likely can avoid these errors in careful mgmt of this role.

[matthewlilley]

uniqueness shouldn't be hard to enforce by adding a check in MasterDeployer and the addToWhitelist function (& storing the identifier for each pool (factory)). So, no extra costs to Trident users. Though, arguably, we likely can avoid these errors in careful mgmt of this role.

Agree. My thoughts were the same, either enforce this on MasterDeployer, or expect that we'd never add a pool type with the same identifier but with different logic (this is why versioning would be nice), none the less there's potential for human error to creep in here which is why the point was made.